Closed Bug 1402695 Opened 7 years ago Closed 7 years ago

Remove undocumented allowScriptsToClose option from windows.create API

Categories

(WebExtensions :: Compatibility, enhancement)

Product:
WebExtensions
Component:
Compatibility
Version:
57 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: robwu, Unassigned)

References

Details

Bug 1301227 added an allowScriptsToClose option to windows.create, but did not document it.

I downloaded and unpacked all add-ons from AMO using https://github.com/cr/webextaware, and did not find any occurrence of "allowScriptsToClose" with grep.

So it seems that this option has never been used. The same functionality can also be achieved by extensions using the browser.windows.remove method, so I don't see a point in keeping this allowScriptsToClose option around.

I suggest to remove the `allowScriptsToClose` option from windows.create (but keep the ability to call window.close if an extension URL was opened, because extensions might be relying on it).
The option is unused because it was never documented.

Instead of removing it, we should document it, as it was proposed and considered useful enough to add by several people/design team.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.