1402848 - ObjectInspector fails to retrieve object properties in object with `length` property

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

This is tracked on GH at https://github.com/devtools-html/devtools-core/issues/707 , and this bug should have a mochitest to make sure we do handle those cases as expected.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1402848 - Add a test case for expanding object with proper length;

In Bug 1403065, we introduce a server fix for that as well as some tests.
But they are testing specific server functions. Adding a test on the client
side will prevent any regression if we end up using other server methods.

Review commit: https://reviewboard.mozilla.org/r/186312/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186312/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8915048 [details]
Bug 1402848 - Add a test case for expanding object with proper length;

https://reviewboard.mozilla.org/r/186312/#review191342

Looks reasonable to me, thanks!

R+ asuming try is green.

Honza

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f91d1b072f46
Add a test case for expanding object with proper length; r=Honza

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f91d1b072f46