1402882 - (Onboarding) Firstrun Images for Nightly, Beta, Release

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: First Run, defect, P1)

Description

[Nevin Chen(Not active on Bugzilla)]

The png file in ttp://searchfox.org/mozilla-central/source/mobile/android/app/src/main/res/drawable-nodpi/firstrun_welcome.png needs update.

Please help

Comment 1

[Carol Huang [:Carol]]

Hi Nevin, 
Here's Nightly images(image_welcome_nightly.png) for onboarding: https://drive.google.com/open?id=0B-9PIePlQZRlXzlEMzRXU2dVSHM
thanks!

Comment 2

[Nevin Chen(Not active on Bugzilla)]

Thanks!
How about beta?

Comment 3

[Carol Huang [:Carol]]

Beta is waiting for Stephen to confirm the final assets.

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Hi Jing Wei.
I think you've done the change?

Comment 5

[Jing-wei Wu [:jwu]]

Attachment: Bug 1402882 - Update firstrun welcome image for nightly/beta/release.

Review commit: https://reviewboard.mozilla.org/r/185956/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185956/

Comment 6

[Jing-wei Wu [:jwu]]

Comment on attachment 8914632 [details]
Bug 1402882 - Update firstrun welcome image for nightly/beta/release.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/185956/diff/1-2/

Comment 7

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8914632 [details]
Bug 1402882 - Update firstrun welcome image for nightly/beta/release.

https://reviewboard.mozilla.org/r/185956/#review191034

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abbe5e6d4de0
Update firstrun welcome image for nightly/beta/release. r=nechen

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/abbe5e6d4de0

Comment 10

[Jing-wei Wu [:jwu]]

Comment on attachment 8914632 [details]
Bug 1402882 - Update firstrun welcome image for nightly/beta/release.

Approval Request Comment
[Feature/Bug causing the regression]:
Update welcome image for beta/release

[User impact if declined]:
No up-to-date welcome icon shown.

[Is this code covered by automated tests?]:
No

[Has the fix been verified in Nightly?]:
Not yet.

[Needs manual test from QE? If yes, steps to reproduce]: 
Yes. Uninstall Fennec and re-install it, then check the firstrun welcome image is correct on beta/release.

[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
The patch only changes image resources.

[String changes made/needed]:
No

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8914632 [details]
Bug 1402882 - Update firstrun welcome image for nightly/beta/release.

Seems like a must fix, beta57+

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e35fe9985d65

Comment 13

[u549602]

Verified as fixed on both Nightly (58.0a1 - 2017-10-08)and latest Beta 57.0b7.
This issue was verified on a Sony Xperia Z5 (Android 6.0.1) and on a Pixel C (Android 7.1.1)