Closed Bug 1402882 Opened 2 years ago Closed 2 years ago

(Onboarding) Firstrun Images for Nightly, Beta, Release

Categories

(Firefox for Android :: First Run, defect, P1)

56 Branch
defect

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
firefox57 --- verified
firefox58 --- verified

People

(Reporter: cnevinchen, Assigned: cnevinchen)

References

(Blocks 1 open bug)

Details

(Whiteboard: [FNC][SPT58.2][MVP])

Attachments

(1 file)

The png file in ttp://searchfox.org/mozilla-central/source/mobile/android/app/src/main/res/drawable-nodpi/firstrun_welcome.png needs update.

Please help
Summary: Firstrun Images for Nightly, Beta, Release → (Onboarding) Firstrun Images for Nightly, Beta, Release
Hi Nevin, 
Here's Nightly images(image_welcome_nightly.png) for onboarding: https://drive.google.com/open?id=0B-9PIePlQZRlXzlEMzRXU2dVSHM
thanks!
Flags: needinfo?(cnevinchen)
Thanks!
How about beta?
Flags: needinfo?(cnevinchen) → needinfo?(chuang)
Beta is waiting for Stephen to confirm the final assets.
Flags: needinfo?(chuang)
Priority: -- → P1
Hi Jing Wei.
I think you've done the change?
Flags: needinfo?(topwu.tw)
Comment on attachment 8914632 [details]
Bug 1402882 - Update firstrun welcome image for nightly/beta/release.

https://reviewboard.mozilla.org/r/185956/#review191034
Attachment #8914632 - Flags: review?(cnevinchen) → review+
Flags: needinfo?(topwu.tw)
Pushed by topwu.tw@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/abbe5e6d4de0
Update firstrun welcome image for nightly/beta/release. r=nechen
https://hg.mozilla.org/mozilla-central/rev/abbe5e6d4de0
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8914632 [details]
Bug 1402882 - Update firstrun welcome image for nightly/beta/release.

Approval Request Comment
[Feature/Bug causing the regression]:
Update welcome image for beta/release

[User impact if declined]:
No up-to-date welcome icon shown.

[Is this code covered by automated tests?]:
No

[Has the fix been verified in Nightly?]:
Not yet.

[Needs manual test from QE? If yes, steps to reproduce]: 
Yes. Uninstall Fennec and re-install it, then check the firstrun welcome image is correct on beta/release.

[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
The patch only changes image resources.

[String changes made/needed]:
No
Attachment #8914632 - Flags: approval-mozilla-beta?
Comment on attachment 8914632 [details]
Bug 1402882 - Update firstrun welcome image for nightly/beta/release.

Seems like a must fix, beta57+
Attachment #8914632 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed on both Nightly (58.0a1 - 2017-10-08)and latest Beta 57.0b7.
This issue was verified on a Sony Xperia Z5 (Android 6.0.1) and on a Pixel C (Android 7.1.1)
Blocks: 1396741
Whiteboard: [FNC][SPT58.2][MVP]
You need to log in before you can comment on or make changes to this bug.