1402935 - ship-it: (probably) incorrect partial for devedition

Status: RESOLVED DUPLICATE of bug 1405137

(Release Engineering :: Applications: Shipit, defect, P2)

Description

[Sylvestre Ledru [:Sylvestre]]

Attachment: Screenshot-2017-9-25 https ship-it mozilla org.png

Starting the 57b3 for devedition, I realized that the partials are probably incorrect. Are we retrieving the right ADI for devedition?
See attachment!

Comment 1

[Rail Aliiev [:rail]]

Looks like we use the Beta ADI numbers.

We should:

1) Make sure to pull the Devedition numbers into https://ship-it.mozilla.org/cron/partial.json by adding devedition to https://github.com/mozilla-releng/ship-it/blob/master/scripts/update-ADI.py

2) https://github.com/mozilla-releng/ship-it/blob/fd6897ccdea5cba09b6b399fa173a118dc66e541/kickoff/static/suggestions.js#L133 should handle devedition separately

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Looks like it's just related to not marking b1 and b2 as shipped. Bug 1405137 has more comments so lets cross the streams and dupe forwards.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

FWIW, I think grabbing ADI for DevEdition is nice to have but not super important. The last three partials is a reasonable approximation.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Agreed