1403048 - Update audioipc prototype to b5559d28 from upstream

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, enhancement, P2)

Description

[Matthew Gregan [:kinetik]]

Update media/audioipc to b5559d28 from upstream.

Comment 1

[Matthew Gregan [:kinetik]]

Try push with default config (i.e. audioipc disabled):

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf357ce1500b291f1785c614ffa8f0d61b35df21

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: Bug 1403048 - Update media/audioipc to b5559d28.

Review commit: https://reviewboard.mozilla.org/r/183466/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183466/

Comment 3

[Matthew Gregan [:kinetik]]

Attachment: Bug 1403048 - Update Rust deps for audioipc.

Review commit: https://reviewboard.mozilla.org/r/183468/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183468/

Comment 4

[Matthew Gregan [:kinetik]]

Try push with audioipc enabled:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b761bb4eee5fbfaf7ef389e9e0a33379f0b2902b

Comment 5

[u480271]

Comment on attachment 8912083 [details]
Bug 1403048 - Update Rust deps for audioipc.

https://reviewboard.mozilla.org/r/183468/#review188616

Looks good to me, but do we need :rillian to official sign off?

Comment 6

[u480271]

Comment on attachment 8912082 [details]
Bug 1403048 - Update media/audioipc to b5559d28.

https://reviewboard.mozilla.org/r/183466/#review188618

Comment 7

[u480271]

Comment on attachment 8912083 [details]
Bug 1403048 - Update Rust deps for audioipc.

Add Ralph to approve rust crate vendoring.

Comment 8

[Ralph Giles (:rillian)]

Comment on attachment 8912083 [details]
Bug 1403048 - Update Rust deps for audioipc.

https://reviewboard.mozilla.org/r/183468/#review188986

Sorry, this is a bit massive to review. In principle the updates are fine, but do you know what deleted all the .cargo-ok files? I'm not sure what those are for, but it looks like they [tell cargo the source package has finished unpacking](https://github.com/rust-lang/cargo/blob/0b9e38225957337997cde1270b3ad5f84a14182a/src/cargo/sources/registry/mod.rs#L294), which sounds like it might cause problems.

Comment 9

[Matthew Gregan [:kinetik]]

cargo-vendor 0.1.12 stopped copying .cargo-ok metadata into the vendored directories, see https://github.com/alexcrichton/cargo-vendor/commit/aa0267a3dd8439b914e6173a7713799ea7790b75

So this is basically just a bunch of (harmless) churn as far as I can tell.  We should probably force |mach vendor rust| to use a specific cargo-vendor version, otherwise every time some unlucky soul runs it with a different cargo-vendor version to the previous run it'll generate another cycle of add/remove churn.

Comment 10

[Ralph Giles (:rillian)]

Comment on attachment 8912083 [details]
Bug 1403048 - Update Rust deps for audioipc.

https://reviewboard.mozilla.org/r/183468/#review188992

I'll buy that.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/676427998df3
Update media/audioipc to b5559d28.  r=kamidphish
https://hg.mozilla.org/integration/autoland/rev/a51ac764452a
Update Rust deps for audioipc.  r=kamidphish,rillian

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/676427998df3
https://hg.mozilla.org/mozilla-central/rev/a51ac764452a