Closed Bug 1403048 Opened 2 years ago Closed 2 years ago

Update audioipc prototype to b5559d28 from upstream

Categories

(Core :: Audio/Video: cubeb, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: kinetik, Assigned: kinetik)

References

Details

Attachments

(2 files)

Update media/audioipc to b5559d28 from upstream.
Comment on attachment 8912083 [details]
Bug 1403048 - Update Rust deps for audioipc.

https://reviewboard.mozilla.org/r/183468/#review188616

Looks good to me, but do we need :rillian to official sign off?
Attachment #8912083 - Flags: review?(dglastonbury) → review+
Comment on attachment 8912082 [details]
Bug 1403048 - Update media/audioipc to b5559d28.

https://reviewboard.mozilla.org/r/183466/#review188618
Attachment #8912082 - Flags: review?(dglastonbury) → review+
Comment on attachment 8912083 [details]
Bug 1403048 - Update Rust deps for audioipc.

Add Ralph to approve rust crate vendoring.
Attachment #8912083 - Flags: review?(giles)
Attachment #8912083 - Flags: review?(giles)
Attachment #8912083 - Flags: review?(giles)
Rank: 15
Priority: -- → P2
Comment on attachment 8912083 [details]
Bug 1403048 - Update Rust deps for audioipc.

https://reviewboard.mozilla.org/r/183468/#review188986

Sorry, this is a bit massive to review. In principle the updates are fine, but do you know what deleted all the .cargo-ok files? I'm not sure what those are for, but it looks like they [tell cargo the source package has finished unpacking](https://github.com/rust-lang/cargo/blob/0b9e38225957337997cde1270b3ad5f84a14182a/src/cargo/sources/registry/mod.rs#L294), which sounds like it might cause problems.
Attachment #8912083 - Flags: review?(giles)
cargo-vendor 0.1.12 stopped copying .cargo-ok metadata into the vendored directories, see https://github.com/alexcrichton/cargo-vendor/commit/aa0267a3dd8439b914e6173a7713799ea7790b75

So this is basically just a bunch of (harmless) churn as far as I can tell.  We should probably force |mach vendor rust| to use a specific cargo-vendor version, otherwise every time some unlucky soul runs it with a different cargo-vendor version to the previous run it'll generate another cycle of add/remove churn.
Comment on attachment 8912083 [details]
Bug 1403048 - Update Rust deps for audioipc.

https://reviewboard.mozilla.org/r/183468/#review188992

I'll buy that.
Attachment #8912083 - Flags: review+
Pushed by mgregan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/676427998df3
Update media/audioipc to b5559d28.  r=kamidphish
https://hg.mozilla.org/integration/autoland/rev/a51ac764452a
Update Rust deps for audioipc.  r=kamidphish,rillian
https://hg.mozilla.org/mozilla-central/rev/676427998df3
https://hg.mozilla.org/mozilla-central/rev/a51ac764452a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Blocks: 1362223
No longer blocks: 1362220
You need to log in before you can comment on or make changes to this bug.