Closed
Bug 1403073
Opened 8 years ago
Closed 8 years ago
stylo: some bindgen object layout issues
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox55 | --- | unaffected |
| firefox56 | --- | unaffected |
| firefox57 | --- | fixed |
| firefox58 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
References
Details
Attachments
(1 file)
|
59 bytes,
text/x-review-board-request
|
xidorn
:
review+
Sylvestre
:
approval-mozilla-beta+
|
Details |
No description provided.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → cam
Status: NEW → ASSIGNED
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8912118 [details]
Bug 1403073 - stylo: Fix some bindgen object layout issues.
https://reviewboard.mozilla.org/r/183490/#review188646
Attachment #8912118 -
Flags: review?(xidorn+moz) → review+
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6fb1f5fae371
stylo: Fix some bindgen object layout issues. r=xidorn
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
||
Comment 5•8 years ago
|
||
Should we uplift this? If not, please mark status-57 as wontfix.
Flags: needinfo?(xidorn+moz)
|
|
||
Comment 6•8 years ago
|
||
I think this is a blocker of struct layout test, and thus would need to be uplifted.
Flags: needinfo?(xidorn+moz)
|
|
||
Updated•8 years ago
|
Flags: needinfo?(cam)
|
|
Assignee | |
Comment 7•8 years ago
|
||
Comment on attachment 8912118 [details]
Bug 1403073 - stylo: Fix some bindgen object layout issues.
Approval Request Comment
[Feature/Bug causing the regression]: N/A
[User impact if declined]: no user impact, but uplifting this change is a requirement for uplifting some Rust/C++ object layout tests that we want to run, which will give us confidence that Stylo can poke at objects safely!
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: very simple patch
[String changes made/needed]: none
Flags: needinfo?(cam)
Attachment #8912118 -
Flags: approval-mozilla-beta?
|
||
Updated•8 years ago
|
status-firefox55:
--- → wontfix
status-firefox56:
--- → wontfix
status-firefox57:
--- → affected
status-firefox-esr52:
--- → wontfix
|
||
Updated•8 years ago
|
|
||
Comment 8•8 years ago
|
||
Comment on attachment 8912118 [details]
Bug 1403073 - stylo: Fix some bindgen object layout issues.
Improve testing, taking it.
Should be in 57b4, gtb tomorrow Thursday
Attachment #8912118 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
|
||
Comment 9•8 years ago
|
||
| bugherder uplift | ||
|
||
Comment 10•8 years ago
|
||
(In reply to Cameron McCormack (:heycam) from comment #7)
> [Is this code covered by automated tests?]: yes
> [Has the fix been verified in Nightly?]: yes
> [Needs manual test from QE? If yes, steps to reproduce]: no
Setting qe-verify- based on Cameron's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•