1403080 - Pass web-platform-test about shippingOptions under https://w3c-test.org/payment-request/payment-request-constructor.https.html

Status: RESOLVED FIXED

(Core :: DOM: Web Payments, enhancement)

Description

[Eden Chuang[:edenchuang]]

According to the spec change, https://github.com/w3c/payment-request/pull/596, our implementation is out of date and fail with related web-platform-tests.

Comment 1

[Eden Chuang[:edenchuang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6fb899b1e0256f771fde0accb7842c2b291fb390

Comment 2

[Eden Chuang[:edenchuang]]

Attachment: Bug 1403080 - Return null instead of empty string when PaymentOptions.requestShipping is false. r?baku

1. Return null instead of empty string while PaymentOptions.requestShipping is false.                                                                 
2. Validate shippingOptions if PaymentOptions.requestShipping is true, according to https://w3c.github.io/payment-request/#constructor step 8.
3. Remove the wrong usage of JS::MutableHandleValue in PaymentResponse.cpp

Comment 3

[Eden Chuang[:edenchuang]]

Attachment: Bug 1403080 - Return null instead of empty string when PaymentOptions.requestShipping is false. r=baku

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4781ee1472b3
Return null DOMString while PaymentOptions.requestShipping is false. r=baku

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4781ee1472b3