Closed Bug 1403080 Opened 2 years ago Closed 2 years ago

Pass web-platform-test about shippingOptions under https://w3c-test.org/payment-request/payment-request-constructor.https.html

Categories

(Core :: DOM: Web Payments, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: edenchuang, Assigned: edenchuang)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

According to the spec change, https://github.com/w3c/payment-request/pull/596, our implementation is out of date and fail with related web-platform-tests.
Assignee: nobody → echuang
Status: NEW → ASSIGNED
1. Return null instead of empty string while PaymentOptions.requestShipping is false.                                                                 
2. Validate shippingOptions if PaymentOptions.requestShipping is true, according to https://w3c.github.io/payment-request/#constructor step 8.
3. Remove the wrong usage of JS::MutableHandleValue in PaymentResponse.cpp
Attachment #8913026 - Flags: review?(amarchesini)
Attachment #8913026 - Flags: review?(amarchesini) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4781ee1472b3
Return null DOMString while PaymentOptions.requestShipping is false. r=baku
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4781ee1472b3
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.