1403132 - Orange color when tapping "Get started" button

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P1)

Description

[Sorina Florean [:sflorean]]

Environment: 
Device: Samsung Galaxy Note 4 (Android 5.0.1);
Build: Nightly 58.0a1 (2017-09-24);

Steps to reproduce:
1. Go to the History Panel -> Synced devices;
2. Tap/long tap on "Get started";
 

Expected result:
The button is highlighted and the color is blue.

Actual result:
The button is highlighted and the color is orange.

Video: https://drive.google.com/open?id=0B0Rtl9OVJNMCeHE4d1BNVllLUWs

Comment 1

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1403132 - Orange color when tapping Get started button.

Review commit: https://reviewboard.mozilla.org/r/187090/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187090/

Comment 2

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8915849 [details]
Bug 1403132 - Orange color when tapping Get started button.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/187090/diff/1-2/

Comment 3

[Jing-wei Wu [:jwu]]

Comment on attachment 8915849 [details]
Bug 1403132 - Orange color when tapping Get started button.

https://reviewboard.mozilla.org/r/187090/#review192190

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8915849 [details]
Bug 1403132 - Orange color when tapping Get started button.

Approval Request Comment
[Feature/Bug causing the regression]: New Photon color should apply here
[User impact if declined]: Users will see wrong color
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]:  no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: Just changing color
[String changes made/needed]: no

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25db67fda015
Orange color when tapping Get started button. r=jwu

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/25db67fda015

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8915849 [details]
Bug 1403132 - Orange color when tapping Get started button.

Photon related, Beta57+

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/569e325d3ee1

Comment 9

[u549602]

Verified as fixed on both Nightly (58.0a1 - 2017-10-08)and latest Beta 57.0b7.
This issue was verified on a Sony Xperia Z5 (Android 6.0.1) and on a Pixel C (Android 7.1.1)

Comment 10

[Ioana Chiorean]

Verified as fixed on both Nightly (58.0a1 - 2017-10-19)and latest Beta 57.0b9
Also per Ninu's comment #9 will set this to Verified Fixed