Closed
Bug 1403132
Opened 7 years ago
Closed 7 years ago
Orange color when tapping "Get started" button
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect, P1)
Tracking
(fennec+, firefox57 verified, firefox58 verified)
VERIFIED
FIXED
Firefox 58
People
(Reporter: sflorean, Assigned: cnevinchen)
References
Details
(Whiteboard: [FNC][SPT58.2][MVP])
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
jwu
:
review+
ritu
:
approval-mozilla-beta+
|
Details |
Environment: Device: Samsung Galaxy Note 4 (Android 5.0.1); Build: Nightly 58.0a1 (2017-09-24); Steps to reproduce: 1. Go to the History Panel -> Synced devices; 2. Tap/long tap on "Get started"; Expected result: The button is highlighted and the color is blue. Actual result: The button is highlighted and the color is orange. Video: https://drive.google.com/open?id=0B0Rtl9OVJNMCeHE4d1BNVllLUWs
Updated•7 years ago
|
Component: General → Theme and Visual Design
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → cnevinchen
Priority: -- → P1
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8915849 [details] Bug 1403132 - Orange color when tapping Get started button. https://reviewboard.mozilla.org/r/187090/#review192190
Attachment #8915849 -
Flags: review?(topwu.tw) → review+
Assignee | ||
Comment 4•7 years ago
|
||
Comment on attachment 8915849 [details] Bug 1403132 - Orange color when tapping Get started button. Approval Request Comment [Feature/Bug causing the regression]: New Photon color should apply here [User impact if declined]: Users will see wrong color [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: no [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: no [Is the change risky?]: no [Why is the change risky/not risky?]: Just changing color [String changes made/needed]: no
Attachment #8915849 -
Flags: approval-mozilla-beta?
Pushed by nechen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/25db67fda015 Orange color when tapping Get started button. r=jwu
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/25db67fda015
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8915849 [details] Bug 1403132 - Orange color when tapping Get started button. Photon related, Beta57+
Attachment #8915849 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 8•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/569e325d3ee1
Verified as fixed on both Nightly (58.0a1 - 2017-10-08)and latest Beta 57.0b7. This issue was verified on a Sony Xperia Z5 (Android 6.0.1) and on a Pixel C (Android 7.1.1)
Updated•7 years ago
|
Whiteboard: [FNC][SPT58.2][MVP]
Comment 10•7 years ago
|
||
Verified as fixed on both Nightly (58.0a1 - 2017-10-19)and latest Beta 57.0b9 Also per Ninu's comment #9 will set this to Verified Fixed
Status: RESOLVED → VERIFIED
Updated•7 years ago
|
tracking-fennec: ? → +
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•