1403137 - Crash in ContinueProcessResponse2 - null mTransactionPump

Status: RESOLVED WORKSFORME

(Core :: Networking, defect, P3)

Description

[Valentin Gosu [:valentin] (he/him)]

(In reply to Moritz Strübe from bug 1396307 comment #36)
> If this is this bug:
> https://crash-stats.mozilla.com/report/index/1b27e2ca-5b2e-495d-84c2-
> fc9bf0170926#tab-bugzilla - I can reproduce this with 100% reliability on a
> TFS-system - thus if there is any way I can help to get this crunched,
> please feel free to contact me.

This crash occurred after the uplift of bug 1396307. It seems the fix doesn't completely handle it.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Thanks for offering to help.

First of all, can you explain when and how you can reproduce the crash?

From what I can tell, these crashes only happen when the passifox extension is installed.
Can you see if this happens with the extension disabled?

Also, can you check in about:config and tell us what the value of network.http.rcwn.enabled is?

Thanks!

Comment 2

[Moritz Strübe]

I can confirm, that disabling PassIFox solves the issue. 
network.http.rcwn.enabled is set to false.

Comment 3

[Valentin Gosu [:valentin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dabf169040caf329911f0737d2e66efe04842ac0

Comment 4

[Valentin Gosu [:valentin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=455e80cb0f0c7e29b31cc6fa677e25231b0f3856&selectedJob=133335384
Can you verify that the problem is fixed? Does the addon still work? Download target.zip from the link above

Comment 5

[Moritz Strübe]

No, PassIFox does not work any more (it activated setting extensions.allow-non-mpc-extensions=true). When right-clicking a form I still get the menu items in the drop down, but it does not fill any forms. Basic Auth does not work at all.

Comment 6

[u279076]

Reports over the last week:
> Firefox 56: 606
> Firefox 57:   2 
> Firefox 58:   0

Volume of crash reports is much higher on Release but that might just be that very few people in Beta are using PassIFox.

Moritz, can you please check if this reproduces for you in Firefox 57 (downloadable from beta.mozilla.org)?

Comment 7

[Moritz Strübe]

(In reply to Anthony Hughes (:ashughes) [QA] from comment #6)
> Reports over the last week:
> > Firefox 56: 606
> > Firefox 57:   2 
> > Firefox 58:   0
> 
> Volume of crash reports is much higher on Release but that might just be
> that very few people in Beta are using PassIFox.
> 
> Moritz, can you please check if this reproduces for you in Firefox 57
> (downloadable from beta.mozilla.org)?

PassIFox is not supported by Quantum anymore. If there is a (hacky) way to get it working again, I can try to do so to verify that the issue is indeed fixed.

Comment 8

[u279076]

Zero crashes so far with Firefox 58 nor 59 and only 2 crashes with Firefox 57, so while this is still technically an issue it's probably not high enough priority to work on. Unless of course someone can find reliable steps to reproduce which does not involve PassIFox so this can be debugged further and fixed.

Comment 9

[Valentin Gosu [:valentin] (he/him)]

There seem to be no more instances of this bug.