1403139 - [Activity Stream] - Top Sites menu is not scrollable

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Activity Stream, defect, P3)

Description

[Bogdan Surd, QA [:bsurd, NI]]

Device:
 - Nexus 6 (Android 7.1.1);

Steps to reproduce:
 1. Open Fennec and rotate device into landscape mode; 
 2. Go into Settings>General>Home.

Expected result:
 Menu is scrollable so that all of the options can be accessed.

Actual result:
 The menu is not scrollable, the "Visited" option can not be accessed in this screen orientation.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Unassigning: we'll hit this in triage and determine if it's important enough for me to look into.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Bug 1403139 - WIP: Add ScrollView around top sites panel preference dialog.

This patch only adds a ScrollView around the bottom container in the top sites
panel. Apparently, by default, the top panel already is scrollable so after
this patch there are two separate scrollable containers in the Top Sites panel
preference dialog: the top and the bottom.

This works, but isn't ideal.

The top container is created with AlertDialog.Builder.setItems while the bottom
is set with a custom layout so I feel like fixing this properly will require a
fully custom dialog for all panel preferences, which also doesn't sound great
given that this only affects a small set of landscape users.

Review commit: https://reviewboard.mozilla.org/r/184222/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184222/

Comment 3

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.