Closed
Bug 1403143
Opened 6 years ago
Closed 6 years ago
Code coverage build on Windows with Clang fails because of a unused namespace
Categories
(Testing :: Code Coverage, defect)
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: marco, Assigned: marco)
References
Details
Attachments
(1 file)
1.89 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8912189 -
Flags: review?(jmaher)
Comment 2•6 years ago
|
||
Comment on attachment 8912189 [details] [diff] [review] Patch Review of attachment 8912189 [details] [diff] [review]: ----------------------------------------------------------------- this seems safe to remove, does this fix the clang builds with coverage?
Attachment #8912189 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 3•6 years ago
|
||
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #2) > Comment on attachment 8912189 [details] [diff] [review] > Patch > > Review of attachment 8912189 [details] [diff] [review]: > ----------------------------------------------------------------- > > this seems safe to remove, does this fix the clang builds with coverage? This + some patches on the llvm/clang side (https://reviews.llvm.org/D38221, https://reviews.llvm.org/D38223, https://reviews.llvm.org/D38224). If you apply all patches, we can build Firefox, but it crashes at startup (bug 1381163 comment 14). N.B.: This is only about Windows; the Linux clang build is running fine, with only some failing tests.
Pushed by mcastelluccio@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2da272c1ad8d Remove useless 'using namespace mozilla::ipc' from CodeCoverageHandler. r=jmaher
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2da272c1ad8d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•