1403143 - Code coverage build on Windows with Clang fails because of a unused namespace

Status: RESOLVED FIXED

(Testing :: Code Coverage, defect)

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8912189 [details] [diff] [review]
Patch

Review of attachment 8912189 [details] [diff] [review]:
-----------------------------------------------------------------

this seems safe to remove, does this fix the clang builds with coverage?

Comment 3

[Marco Castelluccio [:marco]]

(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #2)
> Comment on attachment 8912189 [details] [diff] [review]
> Patch
> 
> Review of attachment 8912189 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> this seems safe to remove, does this fix the clang builds with coverage?

This + some patches on the llvm/clang side (https://reviews.llvm.org/D38221, https://reviews.llvm.org/D38223, https://reviews.llvm.org/D38224).
If you apply all patches, we can build Firefox, but it crashes at startup (bug 1381163 comment 14).

N.B.: This is only about Windows; the Linux clang build is running fine, with only some failing tests.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2da272c1ad8d
Remove useless 'using namespace mozilla::ipc' from CodeCoverageHandler. r=jmaher

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2da272c1ad8d