1403178 - Assertion failure: mParent || !NS_IsMainThread(), at /builds/worker/workspace/build/src/dom/performance/PerformanceEntry.cpp:32

Status: RESOLVED FIXED

(Core :: Networking, defect, P1)

Description

[Jason Kratzer [:jkratzer]]

Attachment: trigger.html

Testcase found while fuzzing mozilla-central rev e6b3498a39b9.  This testcase was found to only reproduce on a headless linux64 system.

Comment 1

[Jason Kratzer [:jkratzer]]

Attachment: Minidump stack trace

Comment 2

[Valentin Gosu [:valentin] (he/him)]

I assume this happens because in headless mode GetParentObject will return null.
Would changing the assertion be enough, or are there any other issues we should worry about?

Comment 3

[Andrea Marchesini [:baku]]

We should remove the same assertion in PerformanceMark, PerformanceMeasure and, in general, make mParent private and not protected. mParent is not used for anything else than GetParentObject().

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1403178 - Remove mParent assertion from Performance* as it's triggered in headless mode

Review commit: https://reviewboard.mozilla.org/r/184466/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184466/

Comment 5

[Andrea Marchesini [:baku]]

Comment on attachment 8913062 [details]
Bug 1403178 - Remove mParent assertion from Performance* as it's triggered in headless mode

https://reviewboard.mozilla.org/r/184466/#review189618

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77229cfe153a
Remove mParent assertion from Performance* as it's triggered in headless mode r=baku

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/77229cfe153a