1403205 - Migrate browser_console_variables_view_while_debugging_and_inspecting.js to the new frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

the test uses the variable view, but we should test the same thing using the object inspector (minus editing) since it has a complex workflow

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1403205 - rename and enable browser_webconsole_object_inspector_while_debugging_and_inspecting.js;

Review commit: https://reviewboard.mozilla.org/r/219178/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219178/

Comment 2

[Julian Descottes [:jdescottes]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=91d9741033a41d5d54a3c952f2865480a9f4421a

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8949860 [details]
Bug 1403205 - rename and enable browser_webconsole_object_inspector_while_debugging_and_inspecting.js;

https://reviewboard.mozilla.org/r/219178/#review225276

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_object_inspector_while_debugging_and_inspecting.js:72
(Diff revision 1)
>    let target = TargetFactory.forTab(gBrowser.selectedTab);
>    let toolbox = gDevTools.getToolbox(target);
>    let thread = toolbox.threadClient;
>  
>    info("Waiting for framesadded");
> -  yield new Promise(resolve => {
> +  return new Promise(resolve => {

Nit: you should be able to `await` instead of return here.

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8949860 [details]
Bug 1403205 - rename and enable browser_webconsole_object_inspector_while_debugging_and_inspecting.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/219178/diff/1-2/

Comment 5

[Julian Descottes [:jdescottes]]

Comment on attachment 8949860 [details]
Bug 1403205 - rename and enable browser_webconsole_object_inspector_while_debugging_and_inspecting.js;

https://reviewboard.mozilla.org/r/219178/#review225276

> Nit: you should be able to `await` instead of return here.

Thanks, fixed!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8b74f789f8c
rename and enable browser_webconsole_object_inspector_while_debugging_and_inspecting.js;r=bgrins

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d8b74f789f8c