Closed Bug 1403210 Opened 3 years ago Closed 3 years ago

Remove iokit AppleSNBFBUserClient access

Categories

(Core :: Security: Process Sandboxing, enhancement, P2)

Unspecified
macOS
enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: Alex_Gaynor, Assigned: Alex_Gaynor)

References

Details

Attachments

(1 file)

This was originally added to ensure we had hardware OpenGL support, but I'm unable to trigger on any hardware accelerated workloads (WebGL, streaming video). I also confirmed that WebKit _used_ to have it, but removed it at some point.

I'll do a full try run to confirm.
Comment on attachment 8912327 [details]
Bug 1403210 - Remove unused access to AppleSNBFBUserClient iokit from content process;

https://reviewboard.mozilla.org/r/183658/#review188852

r+. Regarding how WebKit no longer uses this, do you know if the latest Safari is supported on 10.9? I need to test bug 1401756 on 10.9 and could test this too (later today or tomorrow.)
Attachment #8912327 - Flags: review?(haftandilian) → review+
From researching it, 10.9 hasn't gotten a new Safari in about a year; I'm not sure when Safari removed this permission -- I'll do a full clone of webkit and check.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4a9a6475bf7d
Remove unused access to AppleSNBFBUserClient iokit from content process; r=haik
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4a9a6475bf7d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.