Closed Bug 140324 Opened 23 years ago Closed 16 years ago

NS_ENSURE_TRUE(NS_SUCCEEDED(),) used needlessy in some places

Categories

(Core :: General, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: Morten, Assigned: sgautherie)

References

Details

Attachments

(2 files)

The patch I'm attaching in a second will replace the twelve needless uses in the mozilla tree with NS_ENSURE_SUCCESS(,) it's a small patch, touching four files.
-> me
Assignee: seawood → Morten
Comment on attachment 81157 [details] [diff] [review] proposed patch [Checkin: See comment 6] r=hwaara
Attachment #81157 - Flags: review+
Assignee: Morten → nobody
Comment on attachment 81157 [details] [diff] [review] proposed patch [Checkin: See comment 6] not all pieces still apply, but for those that do...
Attachment #81157 - Flags: superreview?(alecf)
Comment on attachment 81157 [details] [diff] [review] proposed patch [Checkin: See comment 6] wow, someone's got too much time on their hands. you realize this has NO effect on compiled code, right? sr=alecf but lets move on to more important things, shall we? this isn't worth the 20 seconds it took me to review it, let alone fix it.
Attachment #81157 - Flags: superreview?(alecf) → superreview+
Product: Browser → Seamonkey
QA Contact: granrosebugs → build-config
Comment on attachment 81157 [details] [diff] [review] proposed patch [Checkin: See comment 6] >Index: content/html/document/src/nsHTMLContentSink.cpp Checked in (extended): { 3.680 timeless%mozdev.org 2004-05-24 23:09 Bug 140324 NS_ENSURE_TRUE(NS_SUCCEEDED(),) used needlessy in some places patch by Morten@Nilsen.com r=hwaara sr=alecf } >Index: docshell/base/nsDocShell.cpp Checked in: { 1.595 timeless%mozdev.org 2004-05-24 23:09 Bug 140324 NS_ENSURE_TRUE(NS_SUCCEEDED(),) used needlessy in some places patch by Morten@Nilsen.com r=hwaara sr=alecf } >Index: layout/html/base/src/nsObjectFrame.cpp Fixed by { 1.364 bzbarsky%mit.edu 2002-11-19 16:44 Make nsILinkHandler take uris instead of strings. Bug 176904, r=darin, sr=jst } >Index: modules/plugin/base/src/nsPluginViewer.cpp Fixed by { 1.130 bzbarsky%mit.edu 2002-11-19 16:44 Make nsILinkHandler take uris instead of strings. Bug 176904, r=darin, sr=jst }
Attachment #81157 - Attachment description: proposed patch → proposed patch [Checkin: See comment 6]
Severity: normal → trivial
Component: Build Config → General
Depends on: 176904
OS: Linux → All
Product: SeaMonkey → Core
QA Contact: build-config → general
Hardware: x86 → All
Uncompiled, but trivial.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #372285 - Flags: superreview?(bienvenu)
Attachment #372285 - Flags: review?(bienvenu)
Comment on attachment 372285 [details] [diff] [review] (Bv1) </mailnews/> [Checkin: Comment 10] thx, sorry for the delay
Attachment #372285 - Flags: superreview?(bienvenu)
Attachment #372285 - Flags: superreview+
Attachment #372285 - Flags: review?(bienvenu)
Attachment #372285 - Flags: review+
Attachment #372285 - Attachment description: (Bv1) </mailnews/> → (Bv1) </mailnews/> [Checkin: Comment 10]
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: