140324 - NS_ENSURE_TRUE(NS_SUCCEEDED(),) used needlessy in some places

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Morten Nilsen]

The patch I'm attaching in a second will replace the twelve needless uses in the
mozilla tree with NS_ENSURE_SUCCESS(,)

it's a small patch, touching four files.

Comment 1

[Morten Nilsen]

-> me

Comment 2

[Morten Nilsen]

Attachment: proposed patch [Checkin: See comment 6]

Comment 3

[Håkan Waara]

Comment on attachment 81157 [details] [diff] [review]
proposed patch
[Checkin: See comment 6]

r=hwaara

Comment 4

[timeless]

Comment on attachment 81157 [details] [diff] [review]
proposed patch
[Checkin: See comment 6]

not all pieces still apply, but for those that do...

Comment 5

[Alec Flett]

Comment on attachment 81157 [details] [diff] [review]
proposed patch
[Checkin: See comment 6]

wow, someone's got too much time on their hands. you realize this has NO effect
on compiled code, right?
sr=alecf but lets move on to more important things, shall we? this isn't worth
the 20 seconds it took me to review it, let alone fix it.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 81157 [details] [diff] [review]
proposed patch
[Checkin: See comment 6]

>Index: content/html/document/src/nsHTMLContentSink.cpp

Checked in (extended):
{
3.680	timeless%mozdev.org	2004-05-24 23:09	 	Bug 140324 NS_ENSURE_TRUE(NS_SUCCEEDED(),) used needlessy in some places
patch by [e-mail] r=hwaara sr=alecf
}

>Index: docshell/base/nsDocShell.cpp

Checked in:
{
1.595	timeless%mozdev.org	2004-05-24 23:09	 	Bug 140324 NS_ENSURE_TRUE(NS_SUCCEEDED(),) used needlessy in some places
patch by [e-mail] r=hwaara sr=alecf
}

>Index: layout/html/base/src/nsObjectFrame.cpp

Fixed by
{
1.364	bzbarsky%mit.edu	2002-11-19 16:44	 	Make nsILinkHandler take uris instead of strings. Bug 176904, r=darin, sr=jst
}

>Index: modules/plugin/base/src/nsPluginViewer.cpp

Fixed by
{
1.130	bzbarsky%mit.edu	2002-11-19 16:44	 	Make nsILinkHandler take uris instead of strings. Bug 176904, r=darin, sr=jst
}

Comment 7

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) </mailnews/> [Checkin: Comment 10]

Uncompiled, but trivial.

Comment 8

[Serge Gautherie (:sgautherie)]

(In reply to comment #7)
> (Bv1) </mailnews/>

Fixes
http://mxr.mozilla.org/comm-central/search?string=NS_ENSURE_TRUE%5C%28NS_SUCCEEDE&regexp=on&case=on&find=%2Fmailnews%2Fbase%2F.*%5C.cpp%24
which are the only remaining occurrences.

Comment 9

[David :Bienvenu]

Comment on attachment 372285 [details] [diff] [review]
(Bv1) </mailnews/>
[Checkin: Comment 10]

thx, sorry for the delay

Comment 10

[Serge Gautherie (:sgautherie)]

Comment on attachment 372285 [details] [diff] [review]
(Bv1) </mailnews/>
[Checkin: Comment 10]


http://hg.mozilla.org/comm-central/rev/f09d2ec58829