Closed
Bug 140324
Opened 23 years ago
Closed 16 years ago
NS_ENSURE_TRUE(NS_SUCCEEDED(),) used needlessy in some places
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
People
(Reporter: Morten, Assigned: sgautherie)
References
Details
Attachments
(2 files)
4.58 KB,
patch
|
hwaara
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
2.44 KB,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
The patch I'm attaching in a second will replace the twelve needless uses in the
mozilla tree with NS_ENSURE_SUCCESS(,)
it's a small patch, touching four files.
Reporter | ||
Comment 2•23 years ago
|
||
Comment 3•23 years ago
|
||
Comment on attachment 81157 [details] [diff] [review]
proposed patch
[Checkin: See comment 6]
r=hwaara
Attachment #81157 -
Flags: review+
Reporter | ||
Updated•21 years ago
|
Assignee: Morten → nobody
Comment on attachment 81157 [details] [diff] [review]
proposed patch
[Checkin: See comment 6]
not all pieces still apply, but for those that do...
Attachment #81157 -
Flags: superreview?(alecf)
Comment 5•21 years ago
|
||
Comment on attachment 81157 [details] [diff] [review]
proposed patch
[Checkin: See comment 6]
wow, someone's got too much time on their hands. you realize this has NO effect
on compiled code, right?
sr=alecf but lets move on to more important things, shall we? this isn't worth
the 20 seconds it took me to review it, let alone fix it.
Attachment #81157 -
Flags: superreview?(alecf) → superreview+
Updated•21 years ago
|
Product: Browser → Seamonkey
Updated•17 years ago
|
QA Contact: granrosebugs → build-config
Assignee | ||
Comment 6•16 years ago
|
||
Comment on attachment 81157 [details] [diff] [review]
proposed patch
[Checkin: See comment 6]
>Index: content/html/document/src/nsHTMLContentSink.cpp
Checked in (extended):
{
3.680 timeless%mozdev.org 2004-05-24 23:09 Bug 140324 NS_ENSURE_TRUE(NS_SUCCEEDED(),) used needlessy in some places
patch by Morten@Nilsen.com r=hwaara sr=alecf
}
>Index: docshell/base/nsDocShell.cpp
Checked in:
{
1.595 timeless%mozdev.org 2004-05-24 23:09 Bug 140324 NS_ENSURE_TRUE(NS_SUCCEEDED(),) used needlessy in some places
patch by Morten@Nilsen.com r=hwaara sr=alecf
}
>Index: layout/html/base/src/nsObjectFrame.cpp
Fixed by
{
1.364 bzbarsky%mit.edu 2002-11-19 16:44 Make nsILinkHandler take uris instead of strings. Bug 176904, r=darin, sr=jst
}
>Index: modules/plugin/base/src/nsPluginViewer.cpp
Fixed by
{
1.130 bzbarsky%mit.edu 2002-11-19 16:44 Make nsILinkHandler take uris instead of strings. Bug 176904, r=darin, sr=jst
}
Attachment #81157 -
Attachment description: proposed patch → proposed patch
[Checkin: See comment 6]
Assignee | ||
Updated•16 years ago
|
Severity: normal → trivial
Component: Build Config → General
Depends on: 176904
OS: Linux → All
Product: SeaMonkey → Core
QA Contact: build-config → general
Hardware: x86 → All
Assignee | ||
Comment 7•16 years ago
|
||
Uncompiled, but trivial.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #372285 -
Flags: superreview?(bienvenu)
Attachment #372285 -
Flags: review?(bienvenu)
Assignee | ||
Comment 8•16 years ago
|
||
(In reply to comment #7)
> (Bv1) </mailnews/>
Fixes
http://mxr.mozilla.org/comm-central/search?string=NS_ENSURE_TRUE%5C%28NS_SUCCEEDE®exp=on&case=on&find=%2Fmailnews%2Fbase%2F.*%5C.cpp%24
which are the only remaining occurrences.
Comment 9•16 years ago
|
||
Comment on attachment 372285 [details] [diff] [review]
(Bv1) </mailnews/>
[Checkin: Comment 10]
thx, sorry for the delay
Attachment #372285 -
Flags: superreview?(bienvenu)
Attachment #372285 -
Flags: superreview+
Attachment #372285 -
Flags: review?(bienvenu)
Attachment #372285 -
Flags: review+
Assignee | ||
Comment 10•16 years ago
|
||
Comment on attachment 372285 [details] [diff] [review]
(Bv1) </mailnews/>
[Checkin: Comment 10]
http://hg.mozilla.org/comm-central/rev/f09d2ec58829
Attachment #372285 -
Attachment description: (Bv1) </mailnews/> → (Bv1) </mailnews/>
[Checkin: Comment 10]
Assignee | ||
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•