1403289 - When there are no bookmarks in the Bookmarks bar, it shrinks vertically and doesn't stay the same height

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect, P5)

Description

[Jed]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20170926100259

Steps to reproduce:

Removed all bookmarks from the bookmarks bar.


Actual results:

The bookmarks bar shrinked vertically by several pixels.


Expected results:

The bookmarks bar should have stayed the same height. This affects version 57 as well as 58.

Comment 1

[Brandon_Davison]

Is this still active? I was looking to possibly take it on as a first issue.

Comment 2

[:Gijs (he/him)]

(In reply to Brandon_Davison from comment #1)

Is this still active? I was looking to possibly take it on as a first issue.

I haven't tested if it still reproduces but nobody is actively working on this, so you'd be welcome to take it on.

Comment 3

[Nathan Wisner]

Hi everyone, I'm with Brandon on trying to solve this issue, this is our first time working on a large codebase, is there any good way to find the file that controls the bookmark bars behavior?
Thanks

Comment 4

[Marco Bonardo [:mak]]

you can use the Browser Toolbox to inspect the toolbar, that will point you to the css rules controlling it, and it should be enough to handle this problem, I don't think the toolbar code behavior is involved.

Comment 5

[:Gijs (he/him)]

We fixed this with the recent bookmarks improvements.