1403319 - Expose Intl.NumberFormat.prototype.formatToParts

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, enhancement)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Intl.NumberFormat.prototype.formatToParts reached Stage 4 at today's TC39 meeting. We can expose it now to the public! :)

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1403319 - Expose Intl.NumberFormat.prototype.formatToParts.

Review commit: https://reviewboard.mozilla.org/r/184124/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184124/

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Andre, can you take a look? The proposal reached Stage 4 so I'd like to expose it soon.

Also, it would help a lot with our tooling if you could pick a `[:abargull]` or similar nick for bugzilla and MR when requesting reviews from you ;)

Comment 3

[André Bargull [:anba]]

Comment on attachment 8912816 [details]
Bug 1403319 - Expose Intl.NumberFormat.prototype.formatToParts.

https://reviewboard.mozilla.org/r/184124/#review189698

We should now be able to run all NumberFormat.formatToParts tests from test262, so these exclusions should be removed <http://searchfox.org/mozilla-central/rev/f54c1723befe6bcc7229f005217d5c681128fcad/js/src/tests/jstests.list#363-368>, too.

::: js/src/builtin/Intl.cpp
(Diff revision 1)
> -    // enabled, also add it.
> -    if (cx->compartment()->creationOptions().experimentalNumberFormatFormatToPartsEnabled()) {
> -        RootedValue ftp(cx);
> -        HandlePropertyName name = cx->names().formatToParts;
> -        if (!GlobalObject::getSelfHostedFunction(cx, cx->global(),
> -                                                 cx->names().NumberFormatFormatToParts,

Looks like `NumberFormatFormatToParts` and `formatToParts` can both now also be removed from vm/CommonPropertyNames.h.

::: js/src/tests/Intl/NumberFormat/formatToParts.js:1
(Diff revision 1)
> -// |reftest| skip-if(!this.hasOwnProperty("Intl")||typeof(newGlobal)!=="function"||!newGlobal({experimentalNumberFormatFormatToPartsEnabled:true}).Intl.NumberFormat().formatToParts)
> +// |reftest| skip-if(!this.hasOwnProperty("Intl")||typeof(newGlobal)!=="function")

`typeof(newGlobal)!=="function"` can also be removed now.

Comment 4

[André Bargull [:anba]]

(In reply to André Bargull [:anba] from comment #3)
> We should now be able to run all NumberFormat.formatToParts tests from
> test262, so these exclusions should be removed
> <http://searchfox.org/mozilla-central/rev/
> f54c1723befe6bcc7229f005217d5c681128fcad/js/src/tests/jstests.list#363-368>,
> too.

Well, except for this one test which still expects Intl.NumberFormat.prototype.formatToParts.length is 0 instead of 1 <http://searchfox.org/mozilla-central/rev/f54c1723befe6bcc7229f005217d5c681128fcad/js/src/tests/test262/intl402/NumberFormat/prototype/formatToParts/length.js#9>. :-)

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Thanks Andre! Submitted a PR to test262 for the length issue https://github.com/tc39/test262/pull/1249

I'll keep it skipped for now and once we merge updated test262 we can reenable it.

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8912816 [details]
Bug 1403319 - Expose Intl.NumberFormat.prototype.formatToParts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184124/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/353baf72f789
Expose Intl.NumberFormat.prototype.formatToParts. r=anba

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/353baf72f789

Comment 9

[Florian Scholz (Open Web Docs)]

Developer release notes
https://developer.mozilla.org/en-US/Firefox/Releases/58#JavaScript

Reference page
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/NumberFormat/formatToParts

Compat data 
https://github.com/mdn/browser-compat-data/pull/612 (still WIP at this point)