1403325 - Need to add objdir to "sandbox_whitelist_paths" on Windows

Status: RESOLVED FIXED

(Testing :: Reftest, enhancement, P1)

Description

[Andrew Halberstadt [:ahal]]

Bas was hitting an issue when running |mach reftest| on Windows. We discovered it was because his objdir lived outside of topsrcdir and tracked that down to the sandbox whitelist.

There are currently two options that can add to the sandbox whitelist, --work-path and --obj-path. We do pass in the objdir into --obj-path already, but for some reason that only gets added on Linux.

I find these two arguments fairly confusing. I'd prefer a single --sandbox-whitelist argument that can be passed in multiple times. It's more clear what it's for and provides more flexibility in adding additional paths to the whitelist.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1403325 - Use a single --sandbox-read-whitelist argument in mochitest and reftest,

The main bug this fixes is that on reftest, the objdir needs to be added to the
whitelist on Windows. However, this only happens when running on Linux for some
reason.

Changing the --work-path and --obj-path arguments to --sandbox-whitelist was
more of a drive-by cleanup than anything necessary.

Review commit: https://reviewboard.mozilla.org/r/183724/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183724/

Comment 2

[Andrew Halberstadt [:ahal]]

Hey Alex, I flagged you for the review as the author of bug 1374557, but feel free to redirect if needed.

Comment 3

[Alex Gaynor [:Alex_Gaynor]]

Comment on attachment 8912405 [details]
Bug 1403325 - Use a single --sandbox-read-whitelist argument in mochitest and reftest,

https://reviewboard.mozilla.org/r/183724/#review189194

r+ with small nit: please change `sandbox-whitelist` to `sandbox-read-whitelist` for clarity that these paths do not have write permissions.

Comment 4

[Andrew Halberstadt [:ahal]]

Comment on attachment 8912405 [details]
Bug 1403325 - Use a single --sandbox-read-whitelist argument in mochitest and reftest,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/183724/diff/1-2/

Comment 5

[Andrew Halberstadt [:ahal]]

Comment on attachment 8912405 [details]
Bug 1403325 - Use a single --sandbox-read-whitelist argument in mochitest and reftest,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/183724/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35460a8966c7
Use a single --sandbox-read-whitelist argument in mochitest and reftest, r=Alex_Gaynor

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/35460a8966c7

Comment 8

[Boris Zbarsky [:bzbarsky]]

This regressed bug 1392640, which is a blocker for people working on layout.

For future reference, the "for some reason ... on Linux" bit had a reason, and the reason was pretty obvious from looking at the blame...