Closed Bug 1403358 Opened 5 years ago Closed 5 years ago
Disable Accessibility broken by ipc/mscom/Proxy
Stream .cpp:312:5: error: ‘Activation Context’ has not been declared
59 bytes, text/x-review-board-request
In http://searchfox.org/mozilla-central/source/ipc/mscom/ProxyStream.cpp#312 , ActivationContext is only declared if: > #if defined(ACCESSIBILITY) && defined(MOZ_CRASHREPORTER) > #include "mozilla/mscom/ActivationContext.h" But if we build with only CrashReporter and not Accessibility, we get an error. Inside of ProxyStream::ProxyStream() (http://searchfox.org/mozilla-central/source/ipc/mscom/ProxyStream.cpp#272 ) it would be easy to add defined(ACCESSIBILITY) to the guards if that is the correct approach.
Hey Aaron, let me know if you would like me to write a patch that adds the guards (or anything else) or if this is a dupe.
This was either a duplicate of something, or was fixed intentionally or accidentally somewhere else, as it no longer hits.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
--disable-accessibility with --enable-crashreporter is actually still causing this error: > /builds/worker/workspace/build/src/ipc/mscom/ProxyStream.cpp: In lambda function: > /builds/worker/workspace/build/src/ipc/mscom/ProxyStream.cpp:347:5: error: 'ActivationContext' has not been declared > ActivationContext::GetCurrentManifestPath(manifestPath); > ^~~~~~~~~~~~~~~~~ Will try to redo this patch....
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
5 years ago
Priority: -- → P2
Comment on attachment 8912424 [details] Bug 1403358 Only reference ActivationContext if Acessibility is enabled https://reviewboard.mozilla.org/r/183742/#review201276
Attachment #8912424 - Flags: review?(aklotz) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/12f7bd502d4d Only reference ActivationContext if Acessibility is enabled r=aklotz
You need to log in before you can comment on or make changes to this bug.