1403358 - Disable Accessibility broken by ipc/mscom/ProxyStream.cpp:312:5: error: ‘ActivationContext’ has not been declared

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P2)

Description

[Tom Ritter [:tjr] (ni? for response to CVE/sec-approval/advisories/etc)]

In http://searchfox.org/mozilla-central/source/ipc/mscom/ProxyStream.cpp#312 , ActivationContext is only declared if:

> #if defined(ACCESSIBILITY) && defined(MOZ_CRASHREPORTER)
> #include "mozilla/mscom/ActivationContext.h"

But if we build with only CrashReporter and not Accessibility, we get an error.

Inside of ProxyStream::ProxyStream() (http://searchfox.org/mozilla-central/source/ipc/mscom/ProxyStream.cpp#272 ) it would be easy to add defined(ACCESSIBILITY) to the guards if that is the correct approach.

Comment 1

[Tom Ritter [:tjr] (ni? for response to CVE/sec-approval/advisories/etc)]

Hey Aaron, let me know if you would like me to write a patch that adds the guards (or anything else) or if this is a dupe.

Comment 2

[Tom Ritter [:tjr] (ni? for response to CVE/sec-approval/advisories/etc)]

Attachment: Bug 1403358 Only reference ActivationContext if Acessibility is enabled

Review commit: https://reviewboard.mozilla.org/r/183742/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183742/

Comment 3

[Tom Ritter [:tjr] (ni? for response to CVE/sec-approval/advisories/etc)]

This was either a duplicate of something, or was fixed intentionally or accidentally somewhere else, as it no longer hits.

Comment 4

[Tom Ritter [:tjr] (ni? for response to CVE/sec-approval/advisories/etc)]

--disable-accessibility with --enable-crashreporter is actually still causing this error:

>  /builds/worker/workspace/build/src/ipc/mscom/ProxyStream.cpp: In lambda function:
>  /builds/worker/workspace/build/src/ipc/mscom/ProxyStream.cpp:347:5: error: 'ActivationContext' has not been declared
>       ActivationContext::GetCurrentManifestPath(manifestPath);
>       ^~~~~~~~~~~~~~~~~

Will try to redo this patch....

Comment 5

[Tom Ritter [:tjr] (ni? for response to CVE/sec-approval/advisories/etc)]

Breaking try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=94cc5be50903d796d721eb9f075f06460e6f5bb2&selectedJob=139964491

Maybe this fixes it try run:  https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b2ead532689c3aa239b25333de31f7a35cab824

Comment 6

[Tom Ritter [:tjr] (ni? for response to CVE/sec-approval/advisories/etc)]

Comment on attachment 8912424 [details]
Bug 1403358 Only reference ActivationContext if Acessibility is enabled

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/183742/diff/1-2/

Comment 7

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8912424 [details]
Bug 1403358 Only reference ActivationContext if Acessibility is enabled

https://reviewboard.mozilla.org/r/183742/#review201276

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12f7bd502d4d
Only reference ActivationContext if Acessibility is enabled r=aklotz

Comment 9

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/12f7bd502d4d