Closed Bug 1403448 Opened 3 years ago Closed 2 years ago

Migrate browser_longstring_hang.js and browser_longstring_expand.js to the new frontend

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox57 wontfix, firefox58 wontfix, firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox61 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

(Whiteboard: [newconsole-mvp])

Attachments

(1 file)

No description provided.
Depends on: 1310630
Priority: P3 → P2
Whiteboard: [newconsole-mvp]
What about those longstring tests, they all assert that longstrings can be expanded. I don't think this is available in the new console for now? Is this planned?

We could expand the browser_webconsole_string.js to check that an ellipsis is displayed, but I'm not sure the current implementation deserves a dedicated test.
Flags: needinfo?(nchevobbe)
Also should mention, this bug is both about migrating browser_webconsole_longstring_hang and browser_webconsole_longstring_expand (at least the skip-ifs say so in browser.ini)
Summary: Migrate browser_longstring_hang.js to the new frontend → Migrate browser_longstring_hang.js and browser_longstring_expand.js to the new frontend
Yes, this is not supported yet. We have Bug 1310630 for this (oh, and just spotted that this bug already as it as a blocker).

> Also should mention, this bug is both about migrating browser_webconsole_longstring_hang and browser_webconsole_longstring_expand (at least the skip-ifs say so in browser.ini)

Yes, the idea was to gather them in the same test since some assertions in them are already handled in reps tests.
Flags: needinfo?(nchevobbe)
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 8969625 [details]
Bug 1403448 - Migrate longString test to the new frontend; .

https://reviewboard.mozilla.org/r/238412/#review244176

To run the test, patches from Bug 1310630 and Bug 1452566 should be applied.
FWIW, I ran the test on OSX with --verify and there was no failures.
Comment on attachment 8969625 [details]
Bug 1403448 - Migrate longString test to the new frontend; .

https://reviewboard.mozilla.org/r/238412/#review245258

Looks good to me and passes locally on my machine.

R+ assuming try is green

Thanks Nicolas!
Honza
Attachment #8969625 - Flags: review?(odvarko) → review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f731fdfd030
Migrate longString test to the new frontend; r=Honza.
https://hg.mozilla.org/mozilla-central/rev/3f731fdfd030
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.