1403458 - Migrate browser_webconsole_assert.js to the new console

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P3)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1403458 - Convert browser_webconsole_assert.js to a backend test; .

The test ensures that packet are sent for falsy console.assert calls,
and that no packet are sent for truthy console.assert.calls, using a timeout.
Mochitest and support files are removed from the new frontend.

Review commit: https://reviewboard.mozilla.org/r/192406/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192406/

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8921381 [details]
Bug 1403458 - Convert browser_webconsole_assert.js to a backend test; .

https://reviewboard.mozilla.org/r/192406/#review197800

Thanks, this is a much better place for the test!

Comment 3

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s b5fd55067184 -d 7265bb271a9b: rebasing 429587:b5fd55067184 "Bug 1403458 - Convert browser_webconsole_assert.js to a backend test; r=bgrins." (tip)
merging devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
warning: conflicts while merging devtools/client/webconsole/new-console-output/test/mochitest/browser.ini! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8921381 [details]
Bug 1403458 - Convert browser_webconsole_assert.js to a backend test; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/192406/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f415318428e
Convert browser_webconsole_assert.js to a backend test; r=bgrins.

Comment 6

[Attila Craciun [:arny]]

https://hg.mozilla.org/mozilla-central/rev/1f415318428e