Closed
Bug 1403503
Opened 7 years ago
Closed 7 years ago
Remove obsolete socksUsername and socksPassword
Categories
(Testing :: geckodriver, enhancement)
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
Details
Attachments
(1 file)
There are no such keys anymore in the webdriver spec. Instead both values have to be specified as part of the proxy host in the form of: username:password@host username@host Given that this is implicitly given by the webdriver spec we can simply remove those two entries from the table. https://dxr.mozilla.org/mozilla-central/rev/7d15bc419c6cd7e9f3b4d41370c3b0e5990c8d1b/testing/geckodriver/README.md#189-205
|
Assignee | |
Comment 1•7 years ago
|
||
Actually we also validate those keys in webdriver. So lets also kill those lines.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Summary: Remove socksUsername and socksPassword from README.md → Remove obsolete socksUsername and socksPassword
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8913078 -
Flags: review?(ato) → review?(dburns)
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8913078 [details] Bug 1403503 - Remove obsolete socksUsername and socksPassword capabilities. https://reviewboard.mozilla.org/r/184488/#review189870
Attachment #8913078 -
Flags: review?(dburns) → review+
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6f05e80e4bbf Remove obsolete socksUsername and socksPassword capabilities. r=automatedtester
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6f05e80e4bbf
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•