Closed Bug 1403543 Opened 7 years ago Closed 7 years ago

The Developer Toolbar "x" closing button is not visible on Firefox "Dark" theme

Categories

(Firefox :: Theme, defect, P1)

x86_64
All
defect

Tracking

()

VERIFIED FIXED
Firefox 58
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 - verified
firefox58 --- verified

People

(Reporter: poiegas, Assigned: ntim)

References

Details

(Keywords: regression, Whiteboard: [reserve-photon-visual])

Attachments

(2 files)

Attached image developer toolbar.png
[Tracking Requested - why for this release]:

[Affected versions]:
- Nightly 58.0a1 (2017-09-26)
- Firefox Beta 57.0b3 

[Affected Platforms]:
- All Windows
- All Mac OS
- All Linux

[Steps to reproduce]:
1. Open Firefox browser with a new profile.
2. Press "Shift + F2" key combination to open the "Developer Toolbar".
3. Observe the toolbar closing button.
4. Click the Firefox "Menu" button and choose the "Customize" option.
5. From the bottom controls, choose to change the theme to "Dark" one.
6. Click the "Done" button and observe again the Developer Toolbar closing button.

[Expected result]:
- On both themes the toolbar closing button is correctly visible.

[Actual result]:
- On "Dark" theme, even if the toolbar color doesn't change (white), the button and its hover effect do and become invisible.

[Regression]:
I've checked for a regression and found out when this broke. Probably when the developer decided to make the change in #1389939, forgot to also change the button color.

Last good revision: (2017-08-24)
First bad revision: (2017-08-25)
Pushlog: https://goo.gl/gYsdfG
Hi Brian, since this resulted because of your change from #1389939, can you please take a look?
Flags: needinfo?(bgrinstead)
(In reply to Paul Oiegas [:pauloiegasSV], Desktop Engineering QA from comment #1)
> Hi Brian, since this resulted because of your change from #1389939, can you
> please take a look?

This is more likely due to the close icon changes in Bug 1385702 / https://hg.mozilla.org/mozilla-central/rev/04cf5e9b8f72. Tim, would you have a chance to look at this?
Blocks: 1385702
No longer blocks: 1389939
Flags: needinfo?(bgrinstead) → needinfo?(ntim.bugs)
Assignee: nobody → ntim.bugs
Flags: needinfo?(ntim.bugs)
Whiteboard: [photon-visual][triage]
Comment on attachment 8913743 [details]
Bug 1403543 - Fix close button color for developer toolbar in dark themes.

https://reviewboard.mozilla.org/r/185130/#review190154

Thanks!
Attachment #8913743 - Flags: review?(bgrinstead) → review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8f82419ac7c8
Fix close button color for developer toolbar in dark themes. r=bgrins
https://hg.mozilla.org/mozilla-central/rev/8f82419ac7c8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
Comment on attachment 8913743 [details]
Bug 1403543 - Fix close button color for developer toolbar in dark themes.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1385702
[User impact if declined]: invisible close buttons on developer toolbar in some situations
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: yes, see comment 0
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: it's a 1 line CSS fix
[String changes made/needed]: no
Attachment #8913743 - Flags: approval-mozilla-beta?
Comment on attachment 8913743 [details]
Bug 1403543 - Fix close button color for developer toolbar in dark themes.

Photon polish, taking it.
Should be in 57b5
Attachment #8913743 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify? → qe-verify+
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0

I can reproduce this issue with Firefox Nightly 58.0a1 (Build ID 20170926100259) and Firefox Beta 57.0b4 (Build ID: 20170928180207 on Windows 10 x64.

This issue has been verified on latest Firefox Nightly 58.0a1 (Build ID 20171003100226) and Firefox Beta 57.0b5 (Build ID  	20171002181526) on Windows 10 x64, Mac OS 10.13 and Ubuntu 14.04 x64 and it's no longer reproducible.
The Developer Toolbar "[x]" closing button is now correctly visible in all the default Firefox themes.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.