Closed Bug 1403559 Opened 6 years ago Closed 6 years ago

Trim reftest.list entries that reference webrender

Categories

(Core :: Graphics: WebRender, enhancement, P1)

Other Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [wr-mvp] [gfx-noted])

Attachments

(4 files)

Ideally we would have zero reftest.list entries that mention webrender specifically. Right now we have a lot. Some of these can actually be removed right away.
Comment on attachment 8912758 [details]
Bug 1403559 - Remove random-if(webrender) annotations for layers-specific reftests and instead skip the layers checks in the reftest harness.

https://reviewboard.mozilla.org/r/184076/#review189248
Attachment #8912758 - Flags: review?(mstange) → review+
Comment on attachment 8912755 [details]
Bug 1403559 - Remove unnecessary asserts-if clause because we only run webrender reftests with e10s.

https://reviewboard.mozilla.org/r/184070/#review189258
Attachment #8912755 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8912756 [details]
Bug 1403559 - Remove obsolete comments referencing closed webrender bugs.

https://reviewboard.mozilla.org/r/184072/#review189260
Attachment #8912756 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8912757 [details]
Bug 1403559 - Remove random-if webrender annotation from test that's consistently passing now.

https://reviewboard.mozilla.org/r/184074/#review189262
Attachment #8912757 - Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/db9c439a8298
Remove unnecessary asserts-if clause because we only run webrender reftests with e10s. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/a785b7aea1e3
Remove obsolete comments referencing closed webrender bugs. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/0e37a70ad7ce
Remove random-if webrender annotation from test that's consistently passing now. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/5572e837e2d0
Remove random-if(webrender) annotations for layers-specific reftests and instead skip the layers checks in the reftest harness. r=mstange
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [gfx-noted][wr-mvp][triage] → [wr-mvp] [gfx-noted]
The R1 failures were a silly mistake on my part, I accidentally turned a 'fails random-if(webrender)' into '' instead of 'fails-if(layerChecksEnabled)' so it resulted in an UNEXPECTED-FAIL on all non-webrender platforms. And my try push only had webrender. I have it fixed locally, will re-land.
Flags: needinfo?(bugmail)
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/edbbfba4df54
Remove unnecessary asserts-if clause because we only run webrender reftests with e10s. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/9936f2ea4dd2
Remove obsolete comments referencing closed webrender bugs. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/69d317fb5126
Remove random-if webrender annotation from test that's consistently passing now. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/8d7de39443d6
Remove random-if(webrender) annotations for layers-specific reftests and instead skip the layers checks in the reftest harness. r=mstange
You need to log in before you can comment on or make changes to this bug.