1403559 - Trim reftest.list entries that reference webrender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Kartikaya Gupta (email:[e-mail])]

Ideally we would have zero reftest.list entries that mention webrender specifically. Right now we have a lot. Some of these can actually be removed right away.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6caa9cc6ba10eabf28bfd7a9e4d09256c9048ab3

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1403559 - Remove unnecessary asserts-if clause because we only run webrender reftests with e10s.

Review commit: https://reviewboard.mozilla.org/r/184070/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184070/

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1403559 - Remove obsolete comments referencing closed webrender bugs.

Review commit: https://reviewboard.mozilla.org/r/184072/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184072/

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1403559 - Remove random-if webrender annotation from test that's consistently passing now.

Review commit: https://reviewboard.mozilla.org/r/184074/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184074/

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1403559 - Remove random-if(webrender) annotations for layers-specific reftests and instead skip the layers checks in the reftest harness.

Review commit: https://reviewboard.mozilla.org/r/184076/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184076/

Comment 6

[Markus Stange [:mstange]]

Comment on attachment 8912758 [details]
Bug 1403559 - Remove random-if(webrender) annotations for layers-specific reftests and instead skip the layers checks in the reftest harness.

https://reviewboard.mozilla.org/r/184076/#review189248

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8912755 [details]
Bug 1403559 - Remove unnecessary asserts-if clause because we only run webrender reftests with e10s.

https://reviewboard.mozilla.org/r/184070/#review189258

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8912756 [details]
Bug 1403559 - Remove obsolete comments referencing closed webrender bugs.

https://reviewboard.mozilla.org/r/184072/#review189260

Comment 9

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8912757 [details]
Bug 1403559 - Remove random-if webrender annotation from test that's consistently passing now.

https://reviewboard.mozilla.org/r/184074/#review189262

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db9c439a8298
Remove unnecessary asserts-if clause because we only run webrender reftests with e10s. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/a785b7aea1e3
Remove obsolete comments referencing closed webrender bugs. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/0e37a70ad7ce
Remove random-if webrender annotation from test that's consistently passing now. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/5572e837e2d0
Remove random-if(webrender) annotations for layers-specific reftests and instead skip the layers checks in the reftest harness. r=mstange

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing reftest layout/reftests/reftest-sanity/reftest-no-paint.html:

https://hg.mozilla.org/integration/autoland/rev/41025754ffb431a66a6a0311b88528036f50c738
https://hg.mozilla.org/integration/autoland/rev/81520b5c3a92aed8a5107189ca177c4045770f16
https://hg.mozilla.org/integration/autoland/rev/14157a1ab206cd0cafd6773319f8326944e3f895
https://hg.mozilla.org/integration/autoland/rev/2bbc62515048f80a21bccacb7e91eaaf094a96e4

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=5572e837e2d0bebfa5a78724dc40f734c24b8cf7&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=133625445&repo=autoland
> REFTEST TEST-UNEXPECTED-FAIL | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/reftest-sanity/reftest-no-paint.html == file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/reftest-sanity/reftest-no-paint-ref.html | failed reftest-no-paint

Comment 12

[Kartikaya Gupta (email:[e-mail])]

The R1 failures were a silly mistake on my part, I accidentally turned a 'fails random-if(webrender)' into '' instead of 'fails-if(layerChecksEnabled)' so it resulted in an UNEXPECTED-FAIL on all non-webrender platforms. And my try push only had webrender. I have it fixed locally, will re-land.

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8912755 [details]
Bug 1403559 - Remove unnecessary asserts-if clause because we only run webrender reftests with e10s.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184070/diff/1-2/

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8912756 [details]
Bug 1403559 - Remove obsolete comments referencing closed webrender bugs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184072/diff/1-2/

Comment 15

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8912757 [details]
Bug 1403559 - Remove random-if webrender annotation from test that's consistently passing now.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184074/diff/1-2/

Comment 16

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8912758 [details]
Bug 1403559 - Remove random-if(webrender) annotations for layers-specific reftests and instead skip the layers checks in the reftest harness.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184076/diff/1-2/

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edbbfba4df54
Remove unnecessary asserts-if clause because we only run webrender reftests with e10s. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/9936f2ea4dd2
Remove obsolete comments referencing closed webrender bugs. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/69d317fb5126
Remove random-if webrender annotation from test that's consistently passing now. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/8d7de39443d6
Remove random-if(webrender) annotations for layers-specific reftests and instead skip the layers checks in the reftest harness. r=mstange

Comment 18

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/edbbfba4df54
https://hg.mozilla.org/mozilla-central/rev/9936f2ea4dd2
https://hg.mozilla.org/mozilla-central/rev/69d317fb5126
https://hg.mozilla.org/mozilla-central/rev/8d7de39443d6