Closed
Bug 1403593
Opened 7 years ago
Closed 7 years ago
"Enter" and "Space" keys do not work on the buttons from the "about:preferences#containers" page
Categories
(Firefox :: Settings UI, defect, P3)
Firefox
Settings UI
Tracking
()
VERIFIED
FIXED
Firefox 58
People
(Reporter: mcoman, Assigned: jkt)
References
Details
Attachments
(2 files)
[Notes]: - In order to reproduce this issue on Firefox Release, make sure you change following prefs from the "about:config": - privacy.userContext.enabled;true - privacy.userContext.longPressBehavior;2 - privacy.userContext.ui.enabled;true - privacy.usercontext.about_newtab_segregation.enabled;true [Affected versions]: - Firefox Release 55.0.3 - Firefox Beta 57.0b3 - Nightly 58.0a1 [Affected Platforms]: - All Windows - All Mac - All Linux [Steps to reproduce]: 1. Open the browser and access the "about:preferences#containers" page. 2. Focus the first "Remove" button with the "Tab" key. 4. Press "Enter" key and observe the behavior. [Expected result]: - "Personal" container is removed. [Actual result]: - Nothing happens. [Additional Notes]: - If you press "Space" key, the focused button is pressed but nothing happens. - If you press the "Preferences" button, the "Personal Container Preferences" no dialog box appears. - If you press the "Add New Container", the "Add New Container" no dialog box appears. - Attached a screen recording of the issue.
Comment 1•7 years ago
|
||
jkt, can you fix this? I'm guessing you've got "click" event listeners, when we should be using "command" event listeners.
Flags: needinfo?(jkt)
Priority: -- → P3
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jkt
Flags: needinfo?(jkt)
Assignee | ||
Comment 3•7 years ago
|
||
For some reason I thought this was fixed in another bug, thanks both.
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8926019 [details] Bug 1403593 - Change containers preference page to use command instead of click https://reviewboard.mozilla.org/r/197258/#review203476
Attachment #8926019 -
Flags: review?(jaws) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/0d4ab54bbb57 Change containers preference page to use command instead of click r=jaws
Keywords: checkin-needed
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0d4ab54bbb57
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Updated•7 years ago
|
QA Whiteboard: [good first verify]
Comment 7•7 years ago
|
||
[testday-20171208] User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0 OS: Windows_NT 10.0 Status: Fixed & Verified I Have Reproduced the bug and found the bug has been fixed. "Personal" container is removed. After Pressing the Enter Key or just Clicking on Remove Button Hence the bug has been verified.
Updated•7 years ago
|
Updated•7 years ago
|
Comment 8•7 years ago
|
||
[testday-20171208] User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0 OS: Windows_NT 10.0 Status: Fixed & Verified I Have Reproduced the bug and found the bug has been fixed. "Personal" container is removed. After Pressing the Enter Key or just Clicking on Remove Button Hence the bug has been Fixed
Updated•7 years ago
|
status-firefox59:
--- → fixed
Comment 9•7 years ago
|
||
Personal Container Preferences and add new container dialog boxes appears..The bug has been fixed
Flags: needinfo?(marius.coman)
Reporter | ||
Comment 10•7 years ago
|
||
Based on the above comments I'm marking this issue as Verified-Fixed.
Status: RESOLVED → VERIFIED
Flags: needinfo?(marius.coman)
You need to log in
before you can comment on or make changes to this bug.
Description
•