1403593 - "Enter" and "Space" keys do not work on the buttons from the "about:preferences#containers" page

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Notes]:
- In order to reproduce this issue on Firefox Release, make sure you change following prefs from the "about:config":
		- privacy.userContext.enabled;true
		- privacy.userContext.longPressBehavior;2
		- privacy.userContext.ui.enabled;true
		- privacy.usercontext.about_newtab_segregation.enabled;true

[Affected versions]:
- Firefox Release 55.0.3
- Firefox Beta 57.0b3
- Nightly 58.0a1

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Steps to reproduce]:
1. Open the browser and access the "about:preferences#containers" page.
2. Focus the first "Remove" button with the "Tab" key.
4. Press "Enter" key and observe the behavior.

[Expected result]:
- "Personal" container is removed.

[Actual result]:
- Nothing happens.

[Additional Notes]:
- If you press "Space" key, the focused button is pressed but nothing happens.
- If you press the "Preferences" button, the "Personal Container Preferences" no dialog box appears.
- If you press the "Add New Container", the "Add New Container" no dialog box appears.
- Attached a screen recording of the issue.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

jkt, can you fix this? I'm guessing you've got "click" event listeners, when we should be using "command" event listeners.

Comment 2

[Jonathan Kingston [:jkt] he/him]

Attachment: Bug 1403593 - Change containers preference page to use command instead of click

Review commit: https://reviewboard.mozilla.org/r/197258/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197258/

Comment 3

[Jonathan Kingston [:jkt] he/him]

For some reason I thought this was fixed in another bug, thanks both.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8926019 [details]
Bug 1403593 - Change containers preference page to use command instead of click

https://reviewboard.mozilla.org/r/197258/#review203476

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d4ab54bbb57
Change containers preference page to use command instead of click r=jaws

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/0d4ab54bbb57

Comment 7

[Mohammed Adam]

[testday-20171208] 

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
OS: Windows_NT 10.0
Status: Fixed & Verified

I Have Reproduced the bug and found the bug has been fixed. 

"Personal" container is removed. After Pressing the Enter Key or just Clicking on Remove Button

Hence the bug has been verified.

Comment 8

[Mohammed Adam]

[testday-20171208] 

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
OS: Windows_NT 10.0
Status: Fixed & Verified 

I Have Reproduced the bug and found the bug has been fixed. 

"Personal" container is removed. After Pressing the Enter Key or just Clicking on Remove Button

Hence the bug has been Fixed

Comment 9

[krishnaveni]

Personal Container Preferences and add new container dialog boxes appears..The bug has been fixed

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

Based on the above comments I'm marking this issue as Verified-Fixed.