140360 - implement better error handling for Unicode conversion in mail/news

Status: RESOLVED WORKSFORME

(MailNews Core :: Internationalization, defect)

Description

[nhottanscp]

For mail/news, there are chances that we received messages which do not have
charset information specified. As a result, we could encounter Unicode
conversion errors because the charset we assumed is not correct. The current
code bails out when Unicode decoder returns with error code. We want to change
to skip invalid bytes and continue the conversion.

Comment 1

[nhottanscp]

for headers -
http://lxr.mozilla.org/seamonkey/source/mailnews/base/util/nsMsgI18N.cpp#328
for body - 
http://lxr.mozilla.org/seamonkey/source/mailnews/mime/src/mimemoz2.cpp#771
for body quoting - 
http://lxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsMsgCompose.cpp#2144

also need to review other places which uses nsIUnicodeDecoder

Comment 2

[nhottanscp]

Can do similar approach as bug 103954
http://bugzilla.mozilla.org/attachment.cgi?id=55601&action=view

Comment 3

[nhottanscp]

*** Bug 139499 has been marked as a duplicate of this bug. ***

Comment 4

[Wayne Mery (:wsmwk)]

Can you imagine this is still valid?

Comment 5

[ISHIKAWA, Chiaki]

I don't think this problem is serious enough today although I don't rule out occasional error conversion.
(I think more clients are quiet well behaved as far as character set usage is concerned, and I don't think
I encounter such problems often with NEW e-mails any more.
Of course, if I go back in time and look at old e-mail messages, there may be such problematic messages, but
I know they are not that many and I know they are broken and so am OK to deal with such messages with separate editor, etc. to
salvage the content.)

Just my current take on the issue.

Comment 6

[Masatoshi Kimura [:emk]]

I don't think this is still an issue because no nsMsgI18NConvertFromUnicode callers set reportUencNoMapping to true and DecodeWithoutBOMHandling will never return a failure nsresult except OOM.

Comment 7

[Magnus Melin [:mkmelin]]

Let's close this.