1403620 - Icons for taskbar previews missing or broken for pages with SVG icons (notably shipped about: pages) when "Show tab previews in the Windows taskbar" is turned on

Status: NEW

(Core :: Widget: Win32, defect, P3)

Description

[YF (Yang)]

Attachment: Screenshot

Comment 1

[YF (Yang)]

Some internal pages (like about:cache) also have this problem since Fx55.

I got the regression range with twice: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f9ca97a334296facd2e0ea5582e7f12d0fe70fe4&tochange=d712c82c59ec5a277047a75d09bec48be4a64b87

Comment 2

[Cristina Badescu [:cbadescu], Experiments QA]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0; Version: 58.0a1
Build ID: 20170927100120

I will set the flags as "unaffected" for 55 and 56 Firefox versions, considering testing only the "Options" page. But, the "about:cache" page doesn't have any favicon on the tab and indeed is also not displayed in "Show tab preview".

I also ran the Mozregression tool especially for "Options" page. Here are the results:

Last good revision: bebab4283bed00d13ffa71729c0f60eb60c20ada
First bad revision: c4bd4820ca65c3f8ec85c371d018c8e45c5d614e
Pushlog: https://goo.gl/X9tSsy

Richard, can you please take a look at this issue?
While running the Mozregression, I noticed a similar behavior for the "www.amazon.com" and "New Tab" pages, but probably something else affected these pages.

Comment 3

[Richard Marti (:Paenglab)]

It seems when SVG icons are used as favicons, they can't be shown in the tab preview. Maybe the module that creates the previews can't handle SVG.

Unfortunately I don't know who could be asked, if this is the case.

Comment 4

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked since it's a recent regression. Jim, could you please help find an owner if this needs fixing promptly in 57? Thanks.

Comment 5

[Jim Mathies [:jimm]]

I can't identify a bug here. Can I get a better description of what I'm looking for here?

Comment 6

[YF (Yang)]

Turn on "Show tab previews in the Windows taskbar" in Preferences, mouse hover on Firefox icon in Windows taskbar, you can see the Options page icon is blank (Default unknown icon from Windows).

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Given that this was triaged as a P4, I doubt we'll get around to fixing this in 57.

Comment 8

[alex_mayorga]

¡Hola!

Just noticed this while opening about:preferences on Firefox Nightly built from https://hg.mozilla.org/mozilla-central/rev/ee812b6359befd98993f39f8cffd6735ebcd5644

Updated the flags FWIW.

¡Gracias!
Alex