1403687 - Don't use sync text change for events being replayed from DocAccessibleChild deferred event queue

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Patch

Comment 2

[James Teh [:Jamie]]

Comment on attachment 8912862 [details] [diff] [review]
Patch

Looks good!

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6e4edbde66b3b3362e495c86eb27a5ce25d6738
Bug 1403687: Prevent use of SendSyncTextChangeEvent when replaying text changes from DocAccessibleChild deferred event queue; r=Jamie

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d6e4edbde66b

Comment 5

[alexander :surkov (:asurkov)]

Guys, if you provided a short description for the bug, then it'd be good for those who sails through the hg history. It could happen that you only two have a clear idea of what this bug is about.

Comment 6

[James Teh [:Jamie]]

Description:
In order to support IA2 live regions with e10s (bug 1322532), text change events sent from the child process to the parent process use sync IPC. However, if the parent doesn't yet have an associated accessible, we queue events and then push the queued events once the parent is ready. There's no point doing the sync event in this queuing case because content has already moved on by this point. Therefore, if we're pushing a queued event, don't bother with sync IPC.

Comment 7

[(No longer employed by Mozilla) Aaron Klotz]

Thanks Jamie. Sorry Alex, I usually do so but must have forgotten with all the excitement.

Comment 8

[alexander :surkov (:asurkov)]

np, and thanks, Jamie, for the summary! I just looked at the patch, and thought I kinda understand it, but I was missing the context.