1403689 - Allow to pass a PID to Marionette client if it doesn't manage the instance itself

Status: NEW

(Testing :: Marionette Client and Harness, enhancement, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Even if Marionette doesn't manage the instance itself, it will be helpful to have a PID available of the process. Here some examples:

* A call to `wait_for_port` / `raise_for_port` could return early and not after 120s by default, if the process is not running anymore (maybe due to a crash)

* `_handle_socket_failure` could use the pid to at least check if the process is running, and could throw an appropriate exception

Comment 1

[Andreas Tolfsen ❲:ato❳]

I don’t think we should pass a PID to the WebDriver:NewSession
command because the response from session creation will always
include the accurate PID of the current process in the moz:processID
field.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

FYI this is for the Marionette Python client and not the server component. And we would need the PID before `start_session` has been called.

Comment 3

[Andreas Tolfsen ❲:ato❳]

(In reply to Henrik Skupin (:whimboo) from comment #2)

> FYI this is for the Marionette Python client and not the server
> component.  And we would need the PID before `start_session` has
> been called.

Sorry, that wasn’t clear when you talked about “Marionette”.
Things are obviously different for the client because the lifetime
of the Firefox process is managed externally by a FirefoxRunner
instance.  My comment above is irrelevant to this end.

Comment 4

[David Burns :automatedtester]

[Mass Change 2018-01-15] Moving bugs to backlog