Closed Bug 1403723 Opened 7 years ago Closed 7 years ago

management.get doesn't retrieve correct WebExtension metadata

Categories

(WebExtensions :: General, defect)

Product:
WebExtensions
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox57 verified, firefox58 verified)

Status:
VERIFIED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox57 --- verified
firefox58 --- verified

People

(Reporter: evilpie, Assigned: evilpie)

References

Details

Attachments

(2 files)

Correct metadata when using management.get
2.97 KB, patch
mixedpuppy
: review+
Details | Diff | Splinter Review
Animation.gif
780.12 KB, image/gif
Details 
Currently management.get always uses the webextension metadata for the current add-on instead of that for the addon that is being retrieved.

management.getAll already has code for retrieving that information, we just have to copy it.
Blocks: 1282981
Assignee: nobody → evilpies

        Attachment #8912914 -
        Flags: review?(mixedpuppy)

        Attachment #8912914 -
        Flags: review?(mixedpuppy) → review+

    
    

    
  
Please request uplift after this lands

          status-firefox57:
          --- → affected

          status-firefox58:
          --- → affected

    
    

    
  
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b90c6fd05bdc
Correct metadata when using management.get. r=mixedpuppy

    
    

    
  
We should uplift this together with bug 1403721.

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/b90c6fd05bdc
Status: NEW → RESOLVED
Closed: 7 years ago

          status-firefox58:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58

    
    

    
  
Looks like Shane thinks we should have that in 57. wdyt?
Flags: needinfo?(evilpies)

    
    

    
  
I want to uplift this in bug 1403721.
Flags: needinfo?(evilpies)

    
    

    
  

      
      
      
      

        Attached image
          
        Animation.gif
        — 
      

    


  
This issue is verified as fixed on Firefox 58.0a1 (20171010100200) and Firefox 57.0b7 (20171009192146) under Wind 7 64-bit and Ubuntu 16.04 32-bit.

management.getAll function retrieves the informations requested about the extensions and themes, in the browser console for the example presented in the video.

Please see the attached video.

    
  
Status: RESOLVED → VERIFIED

          status-firefox57:
          fixed → verified

          status-firefox58:
          fixed → verified

    
  
Product: Toolkit → WebExtensions

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: