management.get doesn't retrieve correct WebExtension metadata

VERIFIED FIXED in Firefox 57

Status

defect
VERIFIED FIXED
2 years ago
Last year

People

(Reporter: evilpie, Assigned: evilpie)

Tracking

unspecified
mozilla58
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox57 verified, firefox58 verified)

Details

Attachments

(2 attachments)

Currently management.get always uses the webextension metadata for the current add-on instead of that for the addon that is being retrieved.

management.getAll already has code for retrieving that information, we just have to copy it.
Blocks: 1282981
Assignee: nobody → evilpies
Attachment #8912914 - Flags: review?(mixedpuppy)
Attachment #8912914 - Flags: review?(mixedpuppy) → review+
Please request uplift after this lands
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b90c6fd05bdc
Correct metadata when using management.get. r=mixedpuppy
We should uplift this together with bug 1403721.
https://hg.mozilla.org/mozilla-central/rev/b90c6fd05bdc
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Looks like Shane thinks we should have that in 57. wdyt?
Flags: needinfo?(evilpies)
I want to uplift this in bug 1403721.
Flags: needinfo?(evilpies)
Posted image Animation.gif
This issue is verified as fixed on Firefox 58.0a1 (20171010100200) and Firefox 57.0b7 (20171009192146) under Wind 7 64-bit and Ubuntu 16.04 32-bit.

management.getAll function retrieves the informations requested about the extensions and themes, in the browser console for the example presented in the video.

Please see the attached video.
Status: RESOLVED → VERIFIED
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.