1403728 - Additional margin at top and bottom of tabs tray in non-compact portrait mode

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P1)

Description

[Jan Henning [:JanH]]

Attachment: Screenshot_20170927-230554.png

Compare the attached screenshot - as you can see, the tabs are cut off *before* reaching the toolbars at the top and at the bottom of the screen.

This doesn't happen for compact tabs and it also doesn't happen in the pre-Photon non-compact tabs tray.

Comment 1

[Nevin Chen(Not active on Bugzilla)]

Hi Jing Wei. Do you know if there's recent change on this?

Comment 2

[Jim Mathies [:jimm]]

Hey Nevin, what do we plan to do with this for 57?

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1403728 - Remove unwanted padding.

Review commit: https://reviewboard.mozilla.org/r/186634/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186634/

Comment 4

[Nevin Chen(Not active on Bugzilla)]

I"ll request for uplift

Comment 5

[Jing-wei Wu [:jwu]]

Comment on attachment 8915439 [details]
Bug 1403728 - Remove unwanted padding.

https://reviewboard.mozilla.org/r/186634/#review191698

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dacdf390c694
Additional margin at top and bottom of tabs tray in non-compact portrait mode. r=jwu"

Comment 7

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8915439 [details]
Bug 1403728 - Remove unwanted padding.

Approval Request Comment
[Feature/Bug causing the regression]:Photon UI refresh with wrong padding
[User impact if declined]: User will see undesired padding
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]:no
[Is the change risky?]: no 
[Why is the change risky/not risky?]: It just remove padding.
[String changes made/needed]: no

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing android-lint job:

https://hg.mozilla.org/integration/autoland/rev/715a43e874c25d90887582a5e6f5069a8e7a5463

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=dacdf390c6947e636dda22afdbd085d6fbb24bcf&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=135159108&repo=autoland

Comment 9

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8915439 [details]
Bug 1403728 - Remove unwanted padding.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/186634/diff/1-2/

Comment 10

[Nevin Chen(Not active on Bugzilla)]

thx.. I've pushed again

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3e41eff3192
Remove unwanted padding. r=jwu

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f3e41eff3192

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8915439 [details]
Bug 1403728 - Remove unwanted padding.

Photon related, Beta57+

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/781a9f653d27

Comment 15

[u549602]

Verified as fixed on both Nightly (58.0a1 - 2017-10-08)and latest Beta 57.0b7.
This issue was verified on a Sony Xperia Z5 (Android 6.0.1) and on a Pixel C (Android 7.1.1)

Comment 16

[Ioana Chiorean]

As per comment #15 - marking this as VERIFIED FIXED