Closed Bug 1403728 Opened 2 years ago Closed 2 years ago

Additional margin at top and bottom of tabs tray in non-compact portrait mode

Categories

(Firefox for Android :: Theme and Visual Design, defect, P1)

57 Branch
All
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 58
Tracking Status
fennec + ---
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- verified
firefox58 --- verified

People

(Reporter: JanH, Assigned: cnevinchen)

References

(Blocks 2 open bugs)

Details

(Keywords: regression, Whiteboard: [FNC][SPT58.2][MVP])

Attachments

(2 files)

Compare the attached screenshot - as you can see, the tabs are cut off *before* reaching the toolbars at the top and at the bottom of the screen.

This doesn't happen for compact tabs and it also doesn't happen in the pre-Photon non-compact tabs tray.
Hi Jing Wei. Do you know if there's recent change on this?
Flags: needinfo?(topwu.tw)
Assignee: nobody → cnevinchen
Priority: -- → P1
Flags: needinfo?(topwu.tw)
Hey Nevin, what do we plan to do with this for 57?
Flags: needinfo?(cnevinchen)
I"ll request for uplift
Flags: needinfo?(cnevinchen)
Comment on attachment 8915439 [details]
Bug 1403728 - Remove unwanted padding.

https://reviewboard.mozilla.org/r/186634/#review191698
Attachment #8915439 - Flags: review?(topwu.tw) → review+
Pushed by nechen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dacdf390c694
Additional margin at top and bottom of tabs tray in non-compact portrait mode. r=jwu"
Comment on attachment 8915439 [details]
Bug 1403728 - Remove unwanted padding.

Approval Request Comment
[Feature/Bug causing the regression]:Photon UI refresh with wrong padding
[User impact if declined]: User will see undesired padding
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]:no
[Is the change risky?]: no 
[Why is the change risky/not risky?]: It just remove padding.
[String changes made/needed]: no
Attachment #8915439 - Flags: approval-mozilla-beta?
thx.. I've pushed again
Flags: needinfo?(cnevinchen)
https://hg.mozilla.org/mozilla-central/rev/f3e41eff3192
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8915439 [details]
Bug 1403728 - Remove unwanted padding.

Photon related, Beta57+
Attachment #8915439 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed on both Nightly (58.0a1 - 2017-10-08)and latest Beta 57.0b7.
This issue was verified on a Sony Xperia Z5 (Android 6.0.1) and on a Pixel C (Android 7.1.1)
Blocks: 1379655
Whiteboard: [FNC][SPT58.2][MVP]
As per comment #15 - marking this as VERIFIED FIXED
Status: RESOLVED → VERIFIED
tracking-fennec: ? → +
You need to log in before you can comment on or make changes to this bug.