1403754 - Crash in java.lang.NullPointerException: Attempt to invoke virtual method ''android.view.View android.view.ViewStub.inflate()'' on a null object reference at org.mozilla.gecko.home.BrowserSearch.showSuggestionsOptIn(BrowserSearch.java)

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Awesomescreen, defect, P3)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

This bug was filed from the Socorro interface and is 
report bp-45ad923e-6589-40dc-a797-4b1bd0170927.
=============================================================
java.lang.NullPointerException: Attempt to invoke virtual method 'android.view.View android.view.ViewStub.inflate()' on a null object reference
	at org.mozilla.gecko.home.BrowserSearch.showSuggestionsOptIn(BrowserSearch.java:850)
	at org.mozilla.gecko.home.BrowserSearch.setSearchEngines(BrowserSearch.java:804)
	at org.mozilla.gecko.home.BrowserSearch.handleMessage(BrowserSearch.java:484)
	at org.mozilla.gecko.EventDispatcher$2.run(EventDispatcher.java:337)

#17 top crasher in 57 Beta: it's crashed 9 times since Beta has been released.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

fwiw, the Beta was just released so we may not be at the point where the number of crashes is statistically significant enough such that this really deserves to be the #17 top crasher.

Comment 2

[Nevin Chen(Not active on Bugzilla)]

NI Joe and Wesly to help prioritize this

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

fwiw, it's now the #47 top crasher.

Comment 4

[Wesly Huang (EPM)]

#25 in 57.0.4 (count/install = 13/14, while 283/286 in 57.0.1) and still seen in 59.0a1 (#36 top crasher) today so worth checking, added to Sprint 59.5 planning.

Comment 5

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1403754 - Skip browser search opt-in prompt if it's not ready.

The fix will be similar to bug 1317191.

Review commit: https://reviewboard.mozilla.org/r/212000/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212000/

Comment 6

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8941754 [details]
Bug 1403754 - Skip browser search opt-in prompt if it's not ready.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212000/diff/1-2/

Comment 7

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8941754 [details]
Bug 1403754 - Skip browser search opt-in prompt if it's not ready.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212000/diff/2-3/

Comment 8

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8941754 [details]
Bug 1403754 - Skip browser search opt-in prompt if it's not ready.

Another reason could be calling findViewById for ViewStub may return null when the view is already inflated. There might be a timing that mSuggestionsOptInPrompt is null again( maybe [1] or [2])

I'll pause the investigation till I have time again. Anyone who have time please feel free to take it.

[1] https://searchfox.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/home/BrowserSearch.java#951

[2] https://searchfox.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/home/BrowserSearch.java#324

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Non-top crasher but

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

[triage] #31 top FF58 release crasher: 30 crashes in 7 days. Seems non-critical.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.