Closed
Bug 1403808
Opened 7 years ago
Closed 7 years ago
Move mFrameRefCount to GeckoStyleContext
Categories
(Core :: CSS Parsing and Computation, enhancement, P5)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: manishearth, Assigned: manishearth)
Details
Attachments
(1 file)
It's only used for one debug mode assert inside GeckoStyleContext
Assignee | ||
Updated•7 years ago
|
Priority: -- → P5
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8913020 [details] Bug 1403808 - Move mFrameRefCount to GeckoStyleContext; https://reviewboard.mozilla.org/r/184374/#review189610 ::: layout/style/nsStyleContext.cpp:568 (Diff revision 1) > else > return false; > return true; > } > + > +void This needs to be in an `#ifdef DEBUG` block if you don't want to bust release builds.
Attachment #8913020 -
Flags: review?(emilio) → review+
Assignee | ||
Comment 3•7 years ago
|
||
It is, the whole thing is in an ifdef debug
Assignee | ||
Comment 4•7 years ago
|
||
(this will also need a bindings update on the servo side, but that can land separately)
Pushed by manishearth@gmail.com: https://hg.mozilla.org/integration/autoland/rev/31a6dd7f81f9 Move mFrameRefCount to GeckoStyleContext; r=emilio
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/31a6dd7f81f9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•