1403808 - Move mFrameRefCount to GeckoStyleContext

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P5)

Description

[Manish Goregaokar [:manishearth]]

It's only used for one debug mode assert inside GeckoStyleContext

Comment 1

[Manish Goregaokar [:manishearth]]

Attachment: Bug 1403808 - Move mFrameRefCount to GeckoStyleContext;

Review commit: https://reviewboard.mozilla.org/r/184374/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184374/

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8913020 [details]
Bug 1403808 - Move mFrameRefCount to GeckoStyleContext;

https://reviewboard.mozilla.org/r/184374/#review189610

::: layout/style/nsStyleContext.cpp:568
(Diff revision 1)
>    else
>      return false;
>    return true;
>  }
> +
> +void

This needs to be in an `#ifdef DEBUG` block if you don't want to bust release builds.

Comment 3

[Manish Goregaokar [:manishearth]]

It is, the whole thing is in an ifdef debug

Comment 4

[Manish Goregaokar [:manishearth]]

(this will also need a bindings update on the servo side, but that can land separately)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31a6dd7f81f9
Move mFrameRefCount to GeckoStyleContext; r=emilio

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/31a6dd7f81f9