Closed Bug 1403822 Opened 7 years ago Closed 7 years ago

Fix the failure of IndexedDB/interfaces.worker.html in WPT

Categories

(Core :: Storage: IndexedDB, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: bevis, Assigned: bevis)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This failure is introduced when import new revision of wpt in bug 1331899: http://searchfox.org/mozilla-central/diff/bdce75a908f854c51b3953fafb9880b8d8174559/testing/web-platform/meta/IndexedDB/interfaces.worker.js.ini#3 In that revision, the DOMStringList was not added into |untested_idls| IndexedDB/interfaces.worker.js which causes this failure: https://hg.mozilla.org/mozilla-central/file/53c4c315533a/testing/web-platform/tests/IndexedDB/interfaces.worker.js However, this failure was actually fixed later in next import of wpt in bug 1386604 by adding DOMStringList into the |untested_idls| since DOMStringList shall be excluded from the test scope of IDB WebIDLs: http://searchfox.org/mozilla-central/rev/f54c1723befe6bcc7229f005217d5c681128fcad/testing/web-platform/tests/IndexedDB/interfaces.worker.js#28-30 So, I think it shall be safe to remove this IndexedDB/interfaces.worker.js.ini now.
Please see the explanation in comment 0. Treeherder result looks fine, btw: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1343d752b7d09e2256ea1233f28d6968752f403d ni :jgraham to inform that the test passed in newer revision was not captured by the old .ini file as explained in comment 0. (Not sure if this is a test harness issue)
Flags: needinfo?(james)
Attachment #8913083 - Flags: review?(amarchesini)
Attachment #8913083 - Flags: review?(amarchesini) → review+
Pushed by btseng@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/519f00b3168b Fix the failure of IndexedDB/interfaces.worker.html in WPT. r=baku
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
I guess something could have gone wrong with the update; there are enough possible race conditions and ways to introduce errors that I'm not overly worried by one failure :)
Flags: needinfo?(james)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: