1403825 - Address sequence-point warning in widget/windows/TSFTextStore.cpp

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1403825 Resolve sequence-point warning in widget/windows/TSFTextStore.cpp

This warning is saying the operation may be undefined because the value of
->left is not guarenteed to be the same because of undefined order of operations.

Fortunately, this seems like a typo and we actually meant to assign ->bottom

Review commit: https://reviewboard.mozilla.org/r/184434/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184434/

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 8913048 [details]
Bug 1403825 Resolve sequence-point warning in widget/windows/TSFTextStore.cpp

https://reviewboard.mozilla.org/r/184434/#review190330

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7ac83f1710a
Resolve sequence-point warning in widget/windows/TSFTextStore.cpp r=jimm

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e7ac83f1710a