1403873 - Move JitProfilingFrameIterator to JSJitFrameIter.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

An oversight from me: when moving JSJitFrameIter to its own file, I moved the JitProfilingFrameIterator declarations in JSJitFrameIter.h, but didn't move the definitions from JitFrames.cpp. I'll do this once the dust settles in bug 1360211.

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Also, from bug 1360211 comment 65:

> As a follow-up, could jit::JitProfilingFrameIterator be renamed to JSJitProfilingFrameIterator and this method to jsJitIter()?  rs=me :)

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: 1.move.patch

Only code motion: JitProfilingFrameIterator goes to JitFrames.cpp

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

oops: from JitFrames.cpp to JSJitFrameIter.cpp

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: 2.rename.patch

Renamings:
- JitProfilignFrameIterator => JSJitProfilingFrameIterator
- ProfilingFrameIterator::isJit => isJSJit
- ProfilingFrameIterator::jitIter => jsJitIter

Comment 5

[Luke Wagner [:luke]]

Comment on attachment 8914861 [details] [diff] [review]
2.rename.patch

Review of attachment 8914861 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e8398fea724
Move JitProfilingFrameIterator to JSJitFrameIter.cpp; r=jandem
https://hg.mozilla.org/integration/mozilla-inbound/rev/491b7ec95503
Rename JitProfilingFrameIterator to JSJitProfilingFrameIterator; r=luke

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8e8398fea724
https://hg.mozilla.org/mozilla-central/rev/491b7ec95503