1404179 - Intermittent css-ruby/line-breaking-1.html == css-ruby/line-breaking-1-ref.html | image comparison, max difference: 255, number of differing pixels: 252

Status: RESOLVED FIXED

(Core :: Layout, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: nerli [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=133957870&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/Ai9DGGgISdis3YX9HkdgcA/runs/0/artifacts/public/logs/live_backing.log

https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/Ai9DGGgISdis3YX9HkdgcA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Xidorn, looks like this started with your push. Can you please take a look?

Comment 3

[Intermittent Failures Robot]

69 failures in 163 pushes (0.423 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* mozilla-inbound: 29
* autoland: 27
* mozilla-central: 13

Platform breakdown:
* android-4-3-armv7-api16: 45
* windows7-32-stylo-disabled: 11
* linux64: 4
* macosx64-stylo-disabled: 3
* linux64-stylo-disabled: 3
* linux32-stylo-disabled: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1404179&startday=2017-09-29&endday=2017-09-29&tree=all

Comment 4

[Intermittent Failures Robot]

30 failures in 33 pushes (0.909 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* mozilla-inbound: 11
* autoland: 11
* mozilla-central: 8

Platform breakdown:
* android-4-3-armv7-api16: 21
* macosx64-stylo-disabled: 3
* linux32-stylo-disabled: 3
* windows7-32-stylo-disabled: 1
* linux64-stylo-disabled: 1
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1404179&startday=2017-09-30&endday=2017-09-30&tree=all

Comment 5

[Intermittent Failures Robot]

152 failures in 885 pushes (0.172 failures/push) were associated with this bug in the last 7 days. 

This is the #7 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **   

Repository breakdown:
* autoland: 60
* mozilla-central: 46
* mozilla-inbound: 44
* try: 2

Platform breakdown:
* android-4-3-armv7-api16: 97
* windows7-32-stylo-disabled: 22
* macosx64-stylo-disabled: 13
* linux32-stylo-disabled: 11
* linux64: 5
* linux64-stylo-disabled: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1404179&startday=2017-09-25&endday=2017-10-01&tree=all

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

I'll look into this tomorrow.

Comment 7

[Geoff Brown [:gbrown]]

Thanks Xidorn. This is currently one of the most frequent failures.

Comment 10

[Intermittent Failures Robot]

102 failures in 144 pushes (0.708 failures/push) were associated with this bug yesterday.    

** This test has failed more than 200 times in the last 30 days. It should be disabled until it can be fixed. ** 

Repository breakdown:
* autoland: 43
* mozilla-inbound: 32
* mozilla-central: 17
* try: 10

Platform breakdown:
* android-4-3-armv7-api16: 68
* windows7-32-stylo-disabled: 14
* linux64: 7
* macosx64-stylo-disabled: 6
* linux32-stylo-disabled: 5
* linux64-stylo-disabled: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1404179&startday=2017-10-02&endday=2017-10-02&tree=all

Comment 11

[Xidorn Quan [:xidorn] UTC+11]

Attachment: Bug 1404179 - Prepend rather than append frames from overflow list of prev-in-flow for ruby frames.

Review commit: https://reviewboard.mozilla.org/r/185944/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185944/

Comment 12

[Joel Maher ( :jmaher ) (UTC -8)]

:xidorn, any progress here, 100+ failures/day, this is on the border of perma fail- I will disable this tomorrow if I don't hear otherwise.

Comment 13

[Phil Ringnalda (:philor)]

It's not on the border, it's permaorange on Android debug and has been since it landed.

Comment 14

[Daniel Holbert [:dholbert]]

Sorry -- this is just pending my review response, I think.  I intend to get to the review in the next hour or so. (I glanced at it earlier and it looked not-100%-trivial, which is why I haven't gotten to it already.)

(Having said that, I suspect it should be fine to disable the test in the meantime, if it's really permafail and causing trouble.)

Comment 15

[Xidorn Quan [:xidorn] UTC+11]

The patch basically just reverts MoveOverflowToChildList, and duplicates most of its code into a new method MoveInlineOverflowToChildList.

Comment 16

[Daniel Holbert [:dholbert]]

Comment on attachment 8914610 [details]
Bug 1404179 - Prepend rather than append frames from overflow list of prev-in-flow for ruby frames.

https://reviewboard.mozilla.org/r/185944/#review191236

r=me

::: layout/generic/nsContainerFrame.cpp:1558
(Diff revision 1)
> +      // We may need to reparent floats from prev-in-flow to our line
> +      // container if there the container has prev continuation.

There's an extraneous word in here somewhere ("if there the container")

I think you want to drop "there"?

Comment 17

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8914610 [details]
Bug 1404179 - Prepend rather than append frames from overflow list of prev-in-flow for ruby frames.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/185944/diff/1-2/

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d032adb1d58
Prepend rather than append frames from overflow list of prev-in-flow for ruby frames. r=dholbert

Comment 19

[Intermittent Failures Robot]

189 failures in 173 pushes (1.092 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* autoland: 95
* mozilla-inbound: 69
* mozilla-central: 16
* try: 9

Platform breakdown:
* android-4-3-armv7-api16: 139
* windows7-32-stylo-disabled: 14
* linux64: 14
* linux32-stylo-disabled: 11
* linux64-stylo-disabled: 7
* macosx64-stylo-disabled: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1404179&startday=2017-10-03&endday=2017-10-03&tree=all

Comment 20

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1d032adb1d58

Comment 21

[Intermittent Failures Robot]

15 failures in 175 pushes (0.086 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* mozilla-inbound: 13
* try: 2

Platform breakdown:
* android-4-3-armv7-api16: 9
* windows7-32-stylo-disabled: 2
* linux64: 2
* linux64-stylo-disabled: 1
* linux32-stylo-disabled: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1404179&startday=2017-10-04&endday=2017-10-04&tree=all

Comment 22

[Intermittent Failures Robot]

342 failures in 824 pushes (0.415 failures/push) were associated with this bug in the last 7 days. 

This is the #1 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **   

Repository breakdown:
* autoland: 150
* mozilla-inbound: 129
* mozilla-central: 39
* try: 24

Platform breakdown:
* android-4-3-armv7-api16: 246
* windows7-32-stylo-disabled: 35
* linux64: 24
* linux32-stylo-disabled: 17
* macosx64-stylo-disabled: 10
* linux64-stylo-disabled: 10

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1404179&startday=2017-10-02&endday=2017-10-08&tree=all