1404232 - Tab move between different windows does not work well in layers-free mode

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Sotaro Ikeda [:sotaro]]

Tab move between different windows seemed not work well in layers-free mode.

Comment 1

[Sotaro Ikeda [:sotaro]]

I am going to take a look.

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: wip

Comment 3

[Sotaro Ikeda [:sotaro]]

TabMove between different windows on nightly often cause crash at webrender::resource_cache::ResourceCache::get_cached_image.

bp-037115bb-d4fe-46e9-98dd-c870e0171002

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch part 1 - Add WebRenderLayerManager::WrUpdated()

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch part 2 - Add RemoveAndResetAllWebRenderUserData()

Comment 6

[Sotaro Ikeda [:sotaro]]

attachment 8914639 [details] [diff] [review] is a preparation for attachment 8914658 [details] [diff] [review].
attachment 8914658 [details] [diff] [review] adds WebRenderLayerManager::RemoveAndResetAllWebRenderUserData() and use the function as to remove all WebRenderUserData.

Comment 7

[Sotaro Ikeda [:sotaro]]

During working for this bug, I noticed that WebRenderBridgeChild::RecvWrUpdated() sometimes received same wr::IdNamespace since wr::IdNamespace is unique only within same WebRender instance. Therefore different Window(WebRender) could assign same wr::IdNamespace.

Comment 8

[Sotaro Ikeda [:sotaro]]

Bug 1405241 is created for Comment 7.

Comment 9

[Sotaro Ikeda [:sotaro]]

Attachment: patch part 1 - Add WebRenderLayerManager::WrUpdated()

Rebased.

Comment 10

[Sotaro Ikeda [:sotaro]]

Attachment: patch part 2 - Add RemoveAndResetAllWebRenderUserData()

Rebased.

Comment 11

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=16283c2a0e557f7b690f30264b77b212788cd08a

Comment 12

[Sotaro Ikeda [:sotaro]]

Attachment: patch part 1 - Add WebRenderLayerManager::WrUpdated()

Comment 13

[Sotaro Ikeda [:sotaro]]

Attachment: patch part 2 - Remove all WebRenderUserData in WrUpdated()

Comment 14

[Sotaro Ikeda [:sotaro]]

Attachment: patch part 1 - Add WebRenderLayerManager::WrUpdated()

Comment 15

[Sotaro Ikeda [:sotaro]]

Attachment: patch part 2 - Remove all WebRenderUserData in WrUpdated()

Comment 16

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=27b9758c8808da003268518767d7a5c437e51c91

Comment 17

[Sotaro Ikeda [:sotaro]]

Attachment: patch part 2 - WebRenderCommandBuilder::ClearCachedResources()

Comment 18

[Sotaro Ikeda [:sotaro]]

Attachment: patch part 2 - Add WebRenderCommandBuilder::ClearCachedResources()

Comment 19

[Sotaro Ikeda [:sotaro]]

Attachment: patch part 3 - Add mGL->MakeCurrent() calling in SetGLContext()

Comment 20

[Sotaro Ikeda [:sotaro]]

There were cases that DeleteTextureHandle() changed current gl context, it caused texture binding failure. attachment 8919215 [details] [diff] [review] addresses it.

Comment 21

[Sotaro Ikeda [:sotaro]]

When tab is moved between different windows, Wr related resources need to be cleared. attachment 8919213 [details] [diff] [review] does it.

Comment 22

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=09792a8a4bc221e56beb594eecd662910a597505

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fef60dc3adec
Add WebRenderLayerManager::WrUpdated() r=jrmuizel
https://hg.mozilla.org/integration/mozilla-inbound/rev/a88fa8d0eaa0
Add WebRenderCommandBuilder::ClearCachedResources() r=jrmuizel
https://hg.mozilla.org/integration/mozilla-inbound/rev/4212d0d0ca77
Add mGL->MakeCurrent() calling in SetGLContext() r=jrmuizel

Comment 24

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/fef60dc3adec
https://hg.mozilla.org/mozilla-central/rev/a88fa8d0eaa0
https://hg.mozilla.org/mozilla-central/rev/4212d0d0ca77