1404245 - Source map requests don't use stored HTTP basic auth credentials

Status: RESOLVED WORKSFORME

(DevTools :: Debugger, defect, P5)

Description

[Kyle Baker]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170920100426

Steps to reproduce:

I have compiled javascript assets that use a source map. All three pages (the page I'm accessing, the compiled javascript file, and the source map) are all on the same domain behind the same http basic auth protection. I am authenticated and the credentials are saved. Accessing any of the pages directly uses the stored credentials and does not prompt for them.


Actual results:

The source map request made by the dev tools fails with status 401, but accessing the source map directly works.


Expected results:

The source map request should use the stored http basic auth credentials for the domain.

Comment 1

[Jason Laster [:jlast]]

Thanks for filing, we'll have to look at where the source map request is made.

Comment 2

[Yulia Startsev [:yulia]]

related debugger bug: https://github.com/devtools-html/debugger.html/issues/4812

Comment 4

[Jason Laster [:jlast]]

Honza, Kyle, would you be able to try to reproduce this and share a minimal test case? Anecdotally, I've heard from others that this can be a problem.

Comment 5

[Kyle Baker]

I put together a really simple example running express-js with some static assets, a sourcemap, and http basic auth and I couldn't reproduce. I will try again compiled js files instead of css since that is what the original bug was about, but I'm not sure what difference that would make.

Comment 6

[Jason Laster [:jlast]]

Thanks Kyle. Could you share the example in maybe a github repo?

Comment 7

[Kyle Baker]

(In reply to Jason Laster [:jlast] from comment #6)

Thanks Kyle. Could you share the example in maybe a github repo?

See here: https://github.com/kylethebaker/ff-bug-testcase-1404245

The basic auth user/pass combo is (in classic fashion) user:password

I'm currently on Firefox Nightly 66.0a1 (2019-01-24) (64-bit)

This seems to be working with sourcemaps generated for be css and js assets

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: image.png

Thanks for the example Kyle!

JS seems to be working for me. I can see script.ts (source mapped from script.js) in the Debugger panel.

I can also see the styles.css (in Style Editor) nicely formatted (not the same as the HTTP request response data), but not sure if source map is used in this case.

Screenshot attached.

Jason, can you check the CSS mapping?

Honza

Comment 9

[Jason Laster [:jlast]]

I'm not sure what to look for wrt the scss -> css mappings. Martin, would you be able to take a look?