Closed Bug 1404258 Opened 7 years ago Closed 7 years ago

Intermittent Assertion failure: tree.empty(), at /builds/worker/workspace/build/src/js/src/ds/MemoryProtectionExceptionHandler.cpp:67

Categories

(Core :: JavaScript Engine, defect, P3)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: aryx, Assigned: bholley)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:product]) 

https://treeherder.mozilla.org/logviewer.html#?job_id=134006340&repo=autoland

01:16:04     INFO -  [Child 528, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/workspace/build/src/xpcom/base/nsCycleCollector.cpp, line 3691
01:16:04     INFO -  WARNING: YOU ARE LEAKING THE WORLD (at least one JSRuntime and everything alive inside it, that is) AT JS_ShutDown TIME.  FIX THIS!
01:16:04     INFO -  [Child 528, Main Thread] ###!!! ASSERTION: Component Manager being held past XPCOM shutdown.: 'cnt == 0', file /builds/worker/workspace/build/src/xpcom/build/XPCOMInit.cpp, line 1038
01:16:04     INFO -  Leaked URLs:
01:16:04     INFO -    moz-extension://b8bd7055-d80b-1e4e-894b-847a0b67f201/
01:16:04     INFO -    file:///Users/cltbld/tasks/task_1506672496/build/application/NightlyDebug.app/Contents/Resources/omni.ja
01:16:04     INFO -    chrome://pluginproblem/content/pluginProblemBinding.css
01:16:04     INFO -    resource://gre-resources/counterstyles.css

...

01:16:04     INFO -  Assertion failure: tree.empty(), at /builds/worker/workspace/build/src/js/src/ds/MemoryProtectionExceptionHandler.cpp:67
01:16:04     INFO -  Assertion failure: 0 == rv, at /builds/worker/workspace/build/src/nsprpub/pr/src/pthreads/ptthread.c:292
Noticed this in an unrelated Try push, this seems to say that we aren't properly removing all the protected regions while shutting down. The tree of protected regions is a static global [1], so it should be getting destroyed very late during shutdown. Given that this was added for diagnostic purposes I don't know if it's worth worrying about unless it indicates a larger problem.

[1] https://dxr.mozilla.org/mozilla-central/source/js/src/ds/MemoryProtectionExceptionHandler.cpp#93
Flags: needinfo?(bobbyholley)
(In reply to Emanuel Hoogeveen [:ehoogeveen] from comment #4)
> Given that this was added for diagnostic purposes
> I don't know if it's worth worrying about unless it indicates a larger
> problem.

To clarify: I don't know if the code causing this will be in the tree for very much longer.
This is a very-frequent intermittent failure on osx/debug...would be good to do something about it quickly.
Blocks: 1403397
Whiteboard: [stockwell needswork]
I'm removing the diagnostic code in bug 1403397 now.
Flags: needinfo?(bobbyholley)
:bholley as per comment 8, will that fix this intermittent?
Flags: needinfo?(bobbyholley)
Yes: with that backout no one will register any regions with MemoryProtectionExceptionHandler, so the tree will definitely be empty on shutdown.
Flags: needinfo?(bobbyholley)
thanks :ehoogeveen, this looks to be fixed.
Whiteboard: [stockwell needswork] → [stockwell fixed:product]
Priority: -- → P3
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Assignee: nobody → bobbyholley
status-firefox58: affected → fixed
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.