1404258 - Intermittent Assertion failure: tree.empty(), at /builds/worker/workspace/build/src/js/src/ds/MemoryProtectionExceptionHandler.cpp:67

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://treeherder.mozilla.org/logviewer.html#?job_id=134006340&repo=autoland

01:16:04     INFO -  [Child 528, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/workspace/build/src/xpcom/base/nsCycleCollector.cpp, line 3691
01:16:04     INFO -  WARNING: YOU ARE LEAKING THE WORLD (at least one JSRuntime and everything alive inside it, that is) AT JS_ShutDown TIME.  FIX THIS!
01:16:04     INFO -  [Child 528, Main Thread] ###!!! ASSERTION: Component Manager being held past XPCOM shutdown.: 'cnt == 0', file /builds/worker/workspace/build/src/xpcom/build/XPCOMInit.cpp, line 1038
01:16:04     INFO -  Leaked URLs:
01:16:04     INFO -    moz-extension://b8bd7055-d80b-1e4e-894b-847a0b67f201/
01:16:04     INFO -    file:///Users/cltbld/tasks/task_1506672496/build/application/NightlyDebug.app/Contents/Resources/omni.ja
01:16:04     INFO -    chrome://pluginproblem/content/pluginProblemBinding.css
01:16:04     INFO -    resource://gre-resources/counterstyles.css

...

01:16:04     INFO -  Assertion failure: tree.empty(), at /builds/worker/workspace/build/src/js/src/ds/MemoryProtectionExceptionHandler.cpp:67
01:16:04     INFO -  Assertion failure: 0 == rv, at /builds/worker/workspace/build/src/nsprpub/pr/src/pthreads/ptthread.c:292

Comment 1

[Intermittent Failures Robot]

28 failures in 163 pushes (0.172 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* autoland: 15
* mozilla-inbound: 6
* mozilla-central: 4
* try: 3

Platform breakdown:
* osx-10-10: 26
* linux64: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1404258&startday=2017-09-29&endday=2017-09-29&tree=all

Comment 2

[Intermittent Failures Robot]

17 failures in 33 pushes (0.515 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* mozilla-inbound: 10
* autoland: 5
* mozilla-central: 2

Platform breakdown:
* osx-10-10: 16
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1404258&startday=2017-09-30&endday=2017-09-30&tree=all

Comment 3

[Intermittent Failures Robot]

86 failures in 885 pushes (0.097 failures/push) were associated with this bug in the last 7 days. 

This is the #19 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **   

Repository breakdown:
* autoland: 36
* mozilla-inbound: 29
* mozilla-central: 15
* try: 6

Platform breakdown:
* osx-10-10: 83
* linux64: 2
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1404258&startday=2017-09-25&endday=2017-10-01&tree=all

Comment 4

[Emanuel Hoogeveen [:ehoogeveen]]

Noticed this in an unrelated Try push, this seems to say that we aren't properly removing all the protected regions while shutting down. The tree of protected regions is a static global [1], so it should be getting destroyed very late during shutdown. Given that this was added for diagnostic purposes I don't know if it's worth worrying about unless it indicates a larger problem.

[1] https://dxr.mozilla.org/mozilla-central/source/js/src/ds/MemoryProtectionExceptionHandler.cpp#93

Comment 5

[Emanuel Hoogeveen [:ehoogeveen]]

(In reply to Emanuel Hoogeveen [:ehoogeveen] from comment #4)
> Given that this was added for diagnostic purposes
> I don't know if it's worth worrying about unless it indicates a larger
> problem.

To clarify: I don't know if the code causing this will be in the tree for very much longer.

Comment 6

[Geoff Brown [:gbrown]]

This is a very-frequent intermittent failure on osx/debug...would be good to do something about it quickly.

Comment 7

[Intermittent Failures Robot]

34 failures in 144 pushes (0.236 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* autoland: 15
* mozilla-inbound: 12
* mozilla-central: 6
* try: 1

Platform breakdown:
* osx-10-10: 34

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1404258&startday=2017-10-02&endday=2017-10-02&tree=all

Comment 8

[Bobby Holley (:bholley)]

I'm removing the diagnostic code in bug 1403397 now.

Comment 9

[Intermittent Failures Robot]

35 failures in 173 pushes (0.202 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* autoland: 15
* mozilla-inbound: 14
* mozilla-central: 5
* try: 1

Platform breakdown:
* osx-10-10: 33
* windows7-32: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1404258&startday=2017-10-03&endday=2017-10-03&tree=all

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

:bholley as per comment 8, will that fix this intermittent?

Comment 11

[Emanuel Hoogeveen [:ehoogeveen]]

Yes: with that backout no one will register any regions with MemoryProtectionExceptionHandler, so the tree will definitely be empty on shutdown.

Comment 12

[Joel Maher ( :jmaher ) (UTC -8)]

thanks :ehoogeveen, this looks to be fixed.

Comment 13

[Intermittent Failures Robot]

75 failures in 824 pushes (0.091 failures/push) were associated with this bug in the last 7 days. 

This is the #27 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **   

Repository breakdown:
* mozilla-inbound: 30
* autoland: 30
* mozilla-central: 11
* try: 4

Platform breakdown:
* osx-10-10: 72
* windows7-32: 2
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1404258&startday=2017-10-02&endday=2017-10-08&tree=all