1404277 - element.isXULElement() retrieves namespaceURI via attribute but not property

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As MDN explains:
https://developer.mozilla.org/en-US/docs/Web/API/CSSNamespaceRule/namespaceURI

"The CSSNamespaceRule.namespaceURI read-only property returns a DOMString containing the text of the URI of the given namespace."

Not sure why we are trying to retrieve it via getAttribute().

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I assume this is a left-over from the work on bug 1272653 given that the new Selenium atoms no longer conflate attributes and properties.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marking as P1 because it blocks us from upgrading the Selenium atoms, which seem to be necessary to fix other known bugs.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1404277 - Retrieve namespaceURI as property and not attribute.

With newer Selenium atoms which do not conflate attributes and
properties, the retrieval via getElementAttribute will fail. By
retrieving it directly as property will fix it.

Review commit: https://reviewboard.mozilla.org/r/185010/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185010/

Comment 4

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8913618 [details]
Bug 1404277 - Retrieve namespaceURI as property and not attribute.

https://reviewboard.mozilla.org/r/185010/#review190288

Thanks for fixing this.  I actually have a patch for this locally that I hadn’t upstreamed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65a1e4064a52
Retrieve namespaceURI as property and not attribute. r=ato

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/65a1e4064a52

Comment 7

[David Burns :automatedtester]

Comment on attachment 8913618 [details]
Bug 1404277 - Retrieve namespaceURI as property and not attribute.

https://reviewboard.mozilla.org/r/185010/#review190736