Closed Bug 1404277 Opened 2 years ago Closed 2 years ago

element.isXULElement() retrieves namespaceURI via attribute but not property

Categories

(Testing :: Marionette, enhancement, P1)

57 Branch
enhancement

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

As MDN explains:
https://developer.mozilla.org/en-US/docs/Web/API/CSSNamespaceRule/namespaceURI

"The CSSNamespaceRule.namespaceURI read-only property returns a DOMString containing the text of the URI of the given namespace."

Not sure why we are trying to retrieve it via getAttribute().
I assume this is a left-over from the work on bug 1272653 given that the new Selenium atoms no longer conflate attributes and properties.
Marking as P1 because it blocks us from upgrading the Selenium atoms, which seem to be necessary to fix other known bugs.
Priority: -- → P1
Attachment #8913618 - Flags: review?(ato)
Comment on attachment 8913618 [details]
Bug 1404277 - Retrieve namespaceURI as property and not attribute.

https://reviewboard.mozilla.org/r/185010/#review190288

Thanks for fixing this.  I actually have a patch for this locally that I hadn’t upstreamed.
Attachment #8913618 - Flags: review?(ato) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/65a1e4064a52
Retrieve namespaceURI as property and not attribute. r=ato
https://hg.mozilla.org/mozilla-central/rev/65a1e4064a52
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Comment on attachment 8913618 [details]
Bug 1404277 - Retrieve namespaceURI as property and not attribute.

https://reviewboard.mozilla.org/r/185010/#review190736
Attachment #8913618 - Flags: review?(dburns) → review+
You need to log in before you can comment on or make changes to this bug.