1404383 - nsStringBundle preload can fail in content processes leaving the process without localized strings

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Gabor Krizsanits (INACTIVE)]

This is a fall out from bug 1385249.

Comment 1

[Gabor Krizsanits (INACTIVE)]

Attachment: Delay nsStringBundle preloading in content processes. v2

r+ from Olli from bug 1385249 comment 30.

related try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7afe21d28333c1a791fa9a43ce338d52ac8003d&selectedJob=134041589

Comment 2

[Gabor Krizsanits (INACTIVE)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/53f147e1524e1f54beb760addc6129b5b7e4ddfc
Bug 1404383 - Delay nsStringBundle preloading in content processes. r=smaug

Comment 3

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8913739 [details] [diff] [review]
Delay nsStringBundle preloading in content processes. v2

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1363482 (preloading strings)

[User impact if declined]: Preloading localized string bundles might fail, leaving the content process without localized strings forever. This can lead to a wide variety of failures from incorrectly rendering buttons to failing reporting errors and who knows what else. 

[Is this code covered by automated tests?]: Mostly. There can be still edge cases we have not considered, but this patch fixes the ones I can think of and fixed the intermittent failures I know about.

[Has the fix been verified in Nightly?]: Not yet.

[Needs manual test from QE? If yes, steps to reproduce]: I don't think manual testing is possible. Landing the patch under bug 1385249 will do some validation and bug 1401599 should be fixed by this patch as well.

[List of other uplifts needed for the feature/fix]: None.

[Is the change risky?]: It is more risky not taking it.

[Why is the change risky/not risky?]: The worst it can cause is that by delaying the preloading of these strings, it might come with a tiny startup time regression. Not taking it can result misbehaving content processes.

[String changes made/needed]: None.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/53f147e1524e

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8913739 [details] [diff] [review]
Delay nsStringBundle preloading in content processes. v2

Seems like a must fix for 57, Beta57+

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a88f9115bb9c