Closed
Bug 1404451
Opened 8 years ago
Closed 8 years ago
Update color of glass borders around the UI
Categories
(Firefox :: Theme, enhancement, P1)
Tracking
()
RESOLVED
FIXED
Firefox 58
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
(Whiteboard: [reserve-photon-visual])
Attachments
(1 file)
|
59 bytes,
text/x-review-board-request
|
johannh
:
review+
shorlander
:
ui-review+
|
Details |
from bug 1404286 comment 5:
> > > +%define glassShadowColor hsla(209,67%,12%,0.35)
> >
> > Shouldn't this be hsla(240, 5%, 5%, 0.3) (--color-chrome-border-30 from
> > http://design.firefox.com/people/shorlander/photon/Mockups/windows-7.html)?
>
> Not sure. We've been using this value since forever and it seems to work
> well. I suspect Stephen just came up randomly with something different for
> his mockup, not necessarily because it's better than this color. I'll file a
> new bug on potentially changing it.
|
Assignee | |
Comment 1•8 years ago
|
||
Testing this now.
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Flags: qe-verify-
Priority: P4 → P1
|
|
Assignee | |
Comment 2•8 years ago
|
||
Looks okay to me, a bit darker than the old border. Still not sure that this is an improvement though.
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 4•8 years ago
|
||
Comment on attachment 8914663 [details]
Bug 1404451 - Update color of glass borders around the UI. ui-r=shorlander
Try build: https://queue.taskcluster.net/v1/task/XNIMUslvTSmq9qiC1kPVPg/runs/0/artifacts/public/build/target.zip
Attachment #8914663 -
Flags: ui-review?(shorlander)
|
||
Comment 5•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8914663 [details]
Bug 1404451 - Update color of glass borders around the UI. ui-r=shorlander
https://reviewboard.mozilla.org/r/185984/#review191476
Attachment #8914663 -
Flags: review?(jhofmann) → review+
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8914663 [details]
Bug 1404451 - Update color of glass borders around the UI. ui-r=shorlander
LGTM, thanks!
Attachment #8914663 -
Flags: ui-review?(shorlander) → ui-review+
|
|
Assignee | |
Updated•8 years ago
|
status-firefox57:
--- → wontfix
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e3018533b2fb
Update color of glass borders around the UI. ui-r=shorlander r=johannh
|
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
You need to log in
before you can comment on or make changes to this bug.
Description
•