Closed
Bug 1404470
Opened 5 years ago
Closed 5 years ago
Port Bug 1403366 [Stop requiring argv[0] for XRE_GetBinaryPath] to c-c
Categories
(MailNews Core :: Build Config, enhancement)
Tracking
(thunderbird58 affected, seamonkey2.55 affected)
RESOLVED
FIXED
Thunderbird 58.0
People
(Reporter: frg, Assigned: frg)
Details
Attachments
(1 file)
|
5.78 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
InitXPCOMGlue no longer takes argv[0] as a parameter when Bug 1403366 lands.
|
||
Comment 1•5 years ago
|
||
So it becomes: static nsresult InitXPCOMGlue(void)?
|
Assignee | |
Comment 2•5 years ago
|
||
Yes: https://hg.mozilla.org/integration/autoland/rev/3eb67e350f38 Backed out for now.
|
|
Assignee | |
Comment 3•5 years ago
|
||
Looks like a straight 1:1 patch.
Attachment #8913826 -
Flags: review?(jorgk)
|
|
||
Comment 4•5 years ago
|
||
Comment on attachment 8913826 [details] [diff] [review] 1404470-InitXPCOMGlue.patch Looks great, thanks for fixing bustage before it happens ;-)
Attachment #8913826 -
Flags: review?(jorgk) → review+
|
|
||
Comment 5•5 years ago
|
||
This landed on M-C and was backed out: https://hg.mozilla.org/mozilla-central/rev/582d112281f929dedd2b15d073738ddf016d58f8 https://hg.mozilla.org/mozilla-central/rev/cadb2bf153615d095f29c141c3bf93d0db427a48
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/54b88d31ffab Port Bug 1403366 to C-C. Remove argv[0] parameter from XRE_GetBinaryPath. r=jorgk a=frg (SM CLOSED TREE)
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
|
|
||
Comment 7•5 years ago
|
||
Sorry, that got handed on a closed tree since I thought SM was at fault here: remote: ************************** ERROR **************************** remote: comm-central-seamonkey is CLOSED! Reason: jobs not running remote: To push despite the closed tree, include "CLOSED TREE" in your push comment remote: *************************************************************
Target Milestone: --- → Thunderbird 58.0
You need to log in
before you can comment on or make changes to this bug.
Description
•