Closed Bug 1404470 Opened 4 years ago Closed 4 years ago

Port Bug 1403366 [Stop requiring argv[0] for XRE_GetBinaryPath] to c-c

Categories

(MailNews Core :: Build Config, enhancement)

All
Unspecified
enhancement
Not set
normal

Tracking

(thunderbird58 affected, seamonkey2.55 affected)

RESOLVED FIXED
Thunderbird 58.0
Tracking Status
thunderbird58 --- affected
seamonkey2.55 --- affected

People

(Reporter: frg, Assigned: frg)

Details

Attachments

(1 file)

InitXPCOMGlue no longer takes argv[0] as a parameter when Bug 1403366 lands.
So it becomes: static nsresult InitXPCOMGlue(void)?
Looks like a straight 1:1 patch.
Attachment #8913826 - Flags: review?(jorgk)
Comment on attachment 8913826 [details] [diff] [review]
1404470-InitXPCOMGlue.patch

Looks great, thanks for fixing bustage before it happens ;-)
Attachment #8913826 - Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/54b88d31ffab
Port Bug 1403366 to C-C. Remove argv[0] parameter from XRE_GetBinaryPath. r=jorgk a=frg (SM CLOSED TREE)
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Sorry, that got handed on a closed tree since I thought SM was at fault here:

remote: ************************** ERROR ****************************
remote: comm-central-seamonkey is CLOSED! Reason: jobs not running
remote: To push despite the closed tree, include "CLOSED TREE" in your push comment
remote: *************************************************************
Target Milestone: --- → Thunderbird 58.0
You need to log in before you can comment on or make changes to this bug.