Closed Bug 1404536 Opened 4 years ago Closed 4 years ago

GLBlitHelper should use a 3x4 matrix for the color matrix, where possible

Categories

(Core :: Graphics, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox56 --- fix-optional
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

(Whiteboard: gfx-noted)

Attachments

(4 files)

Support for non-square matrices was added to GL 2.1 (GLSL 120) and ES 3.0 (ESSL 300).

Also note that while we need a 3x4 matrix (3 rows, 4 cols) here, in GL notation this is called a 4x3 matrix.
Comment on attachment 8913912 [details]
Bug 1404536 - Use 3x4 matrices for GLBlitHelper's color matrix. -

https://reviewboard.mozilla.org/r/185312/#review190326

LGTM. thanks.
Attachment #8913912 - Flags: review?(dmu) → review+
Blocks: 1395497
Comment on attachment 8920402 [details]
Bug 1404536 - Use mat3s to transform tex coords in GLBlitHelper. -

r+ from bug 1395497
Attachment #8920402 - Flags: review?(dmu) → review+
Comment on attachment 8920403 [details]
Bug 1404536 - ESSL3 needs texture() not texture2D(). -

r+ from bug 1395497
Attachment #8920403 - Flags: review?(snorp) → review+
Comment on attachment 8920402 [details]
Bug 1404536 - Use mat3s to transform tex coords in GLBlitHelper. -

https://reviewboard.mozilla.org/r/191366/#review196592

LGTM
Attachment #8920402 - Flags: review+
I see an r+, but no comment as to why this isn't landed?  should we land this?
Comment on attachment 8920403 [details]
Bug 1404536 - ESSL3 needs texture() not texture2D(). -

Already r+'d.
Attachment #8920403 - Flags: review?(snorp) → review+
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #11)
> I see an r+, but no comment as to why this isn't landed?  should we land
> this?

It wasn't green on try.
Comment on attachment 8922579 [details]
Bug 1404536 - Use float division not accidentally int division. -

https://reviewboard.mozilla.org/r/193690/#review198824

LGTM.
Attachment #8922579 - Flags: review?(dmu) → review+
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a7ca23da073
Use mat3s to transform tex coords in GLBlitHelper. - r=daoshengmu
https://hg.mozilla.org/integration/mozilla-inbound/rev/471908002f68
Use 3x4 matrices for GLBlitHelper's color matrix. - r=daoshengmu
https://hg.mozilla.org/integration/mozilla-inbound/rev/16d08b2e85fc
ESSL3 needs texture() not texture2D(). - r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/df54b8eb4cec
Use float division not accidentally int division. - r=daoshengmu
You need to log in before you can comment on or make changes to this bug.