1404578 - test_async_batchUpdatesForNode.js should be under browser/ not toolkit/

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Jorg K (CEST = GMT+2)]

First seen: Sat Sep 30, 2017, 1:48:57

TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/unit/test_async_batchUpdatesForNode.js

M-C last good: cd9c8c48e4b3ded47a776f757008f3dcf5
M-C first bad: 57f68296c350469d73d788eb3695a89894

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cd9c8c48e4b3ded47a776f757008f3dcf5&tochange=57f68296c350469d73d788eb3695a89894

Seems to be related to bug 1392533.

Mark and Marco, could you please advise me what I need to do so this test doesn't fail in the Thunderbird Xpcshell suite.

I have the impression that this introduces a(n) (undesired) dependency between browser and toolkit.

Comment 1

[Mark Banner (:standard8)]

Oops. Marco asked me to move the added function from PlacesTransactions.jsm to PlacesUiUtils.jsm and I forgot that it moved from toolkit to browser. The test just needs moving to browser. I can pick this up on Monday unless anyone wants to do it before then.

Comment 2

[Jorg K (CEST = GMT+2)]

Thanks, Mark, not me. I have plenty of other bustage at hand.

Comment 3

[Marco Bonardo [:mak]]

ah oops, yes the test should be moved to browser/components/places/tests/browser

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1404578 - test_async_batchUpdatesForNode.js should be under browser/ not toolkit/.

Review commit: https://reviewboard.mozilla.org/r/185572/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185572/

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 8914250 [details]
Bug 1404578 - test_async_batchUpdatesForNode.js should be under browser/ not toolkit/.

https://reviewboard.mozilla.org/r/185572/#review190528

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a213a36e39d
test_async_batchUpdatesForNode.js should be under browser/ not toolkit/. r=mak

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9a213a36e39d

Comment 8

[Jorg K (CEST = GMT+2)]

Thanks Mark and Marco!