1404601 - undeclared variable debug in nsSidebar.js

Status: RESOLVED FIXED

(SeaMonkey :: Sidebar, defect)

Description

[Frank-Rainer Grahl (:frg)]

+++ This bug was initially created as a clone of Bug #1402671 +++

Variable debug is never declared in suite\common\src\nsSidebar.js

Error is almost identical to the one in bug 1402671.

> Timestamp: 9/30/2017, 12:55:28 PM
> Error: ReferenceError: assignment to undeclared variable debug
> Source File: file:///D:/seabuild/release/comm-beta-15/obj-x86_64-pc-mingw32/dist/bin/components/nsSidebar.js
> Line: 319

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1404601-debug.patch

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8913947 [details] [diff] [review]
1404601-debug.patch

[Approval Request Comment]
Regression caused by (bug #): Bug 1186409
User impact if declined: sidebar broken.
Testing completed (on m-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): none already broken.
String changes made by this patch: none

I am not sure it is the right bug number which broke it. Most code is now compiled in strict mode and this is what chauses this.

Comment 3

[Ian Neal]

Comment on attachment 8913947 [details] [diff] [review]
1404601-debug.patch

LGTM r/a=me

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/36be15c040d5
Declare and rename debug function in nsSidebar.js. r=IanN

Comment 5

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-beta/rev/f1b007502af6cee39e705049ec5940aacb91f141