1404665 - Long font names with similar start in Preferences are indistinguishable

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Alice0775 White]

Attachment: screenshot comparison beta(57.0b4) vs current(56.0.0)

[Tracking Requested - why for this release]: The photon does not make sense. The preferences is completely unusable.

+++ This bug was initially created as a clone of Bug #1399963 +++

Build identifier:
Build ID 20170928180207
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Reproducible : always

Steps To Reproduce:
1. Open Preferences
2. Click select box of font list


Actual Results:
See screenshot

Font name is too short, indistinguishable.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

@Alice0775: Would you be able to take a screenshot of the same interface in Firefox 55?  I'd like to compare it to the new screenshot to understand the difference better.

Comment 2

[Alice0775 White]

Attachment: screenshot of outdated version 55.0.3

Comment 3

[Ricky Chien [:rickychien] (inactive)]

I believe this is due to Photon visual refresh work from bug 1386514, but it doesn't relate to bug 1399963. In bug 1386514, the width of Preferences content area has been shrunk, causing the font family menulist to be shrunk as well. 

Per discussion with Helen (Preferences visual designer), we decided to remove the additional spacer between font-size and advanced button to increase the width of font family menulist.

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1404665 - Extend font family menulist by removing spacer in Preferences font & color section

Review commit: https://reviewboard.mozilla.org/r/185468/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185468/

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8914148 [details]
Bug 1404665 - Extend font family menulist by removing spacer in Preferences font & color section

https://reviewboard.mozilla.org/r/185468/#review190604

::: commit-message-41286:1
(Diff revision 1)
> +Bug 1404665 - Remove spacer in Preferecens font & color section r?jaws

This commit message needs to say *why* this is being removed. It's obvious from looking at the patch that it is being removed.

Also, spelling error, "Preferences" instead of "Preferecens".

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8914148 [details]
Bug 1404665 - Extend font family menulist by removing spacer in Preferences font & color section

https://reviewboard.mozilla.org/r/185468/#review190608

Since our timezones are far apart I don't want to make the patch wait another 12-24 hours so I'll grant r+ now but the commit message needs to be changed before landing.

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8914148 [details]
Bug 1404665 - Extend font family menulist by removing spacer in Preferences font & color section

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/185468/diff/1-2/

Comment 8

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8914148 [details]
Bug 1404665 - Extend font family menulist by removing spacer in Preferences font & color section

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/185468/diff/2-3/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc3a6c6be8cc
Extend font family menulist by removing spacer in Preferences font & color section r=jaws

Comment 10

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8914148 [details]
Bug 1404665 - Extend font family menulist by removing spacer in Preferences font & color section

Approval Request Comment
[Feature/Bug causing the regression]: bug 1386514
[User impact if declined]: minor, UI polish
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: see description
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: minor
[Why is the change risky/not risky?]: UI polish
[String changes made/needed]: none

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dc3a6c6be8cc

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8914148 [details]
Bug 1404665 - Extend font family menulist by removing spacer in Preferences font & color section

Low risk, polish, makes sense, Beta57+

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d6424c273328

Comment 14

[Vlad Bacia-Mociran [:VladB]]

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20171004100049

This issue has been verified on latest Firefox Nightly Build ID: 20171004100049 on Windows 8.1 x64, Mac OS 10.11 and Ubuntu 14.04 and it is not reproducible. Now, the long font names are visible.

This issue is still reproducible on Firefox Beta 57.0b5.

Comment 15

[Hani Yacoub, Desktop QA]

Build ID: 20171009192146
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Beta 57.0b7 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.12 and Ubuntu 16.04 x64.