1404674 - Focus doesn't move to content after clicking Home button with custom web page

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[blinky]

Steps to reproduce:

1. Set https://www.google.com as home page.
2. Click the home button.
3. Start typing.


Actual results:

Url bar has focus and you start typing in there.


Expected Results:

The search engine box should have focus.

Comment 1

[blinky]

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c6d94140d11b651cae7bdf8b44ddc028ebea94eb&tochange=cd91b8be78f6026f0fabd0ea2566aef82543b1ec

Comment 2

[Jan Henning [:JanH]]

This can't be right, as that changeset affects only Android (and not even the UI at that).

Comment 3

[Marco Bonardo [:mak]]

I'm not up-to-date with recent focus changes. Mardak, any idea?

Comment 4

[Ed Lee :Mardak]

It's on purpose that focus is in the address bar.

Comment 5

[Marco Bonardo [:mak]]

(In reply to Ed Lee :Mardak from comment #4)
> It's on purpose that focus is in the address bar.

That bug seems to be only about about:home, but here the user has set a custom home page (google), thus we are effectively stealing focus from the page. Expected?

Comment 6

[Ed Lee :Mardak]

Oh oops. I don't think that was explicitly discussed for custom `about:home`s, but I would guess focus should move to content. I do see the problem only if the focus is already in the address bar (or search bar). This was regressed by bug 1399454.

dao, I would guess we need to do some checks not only on new windows but also on "home" button clicks?

Comment 7

[Dão Gottwald [:dao]]

Attachment: Bug 1404674 - Clicking the home button should focus the content area.

Review commit: https://reviewboard.mozilla.org/r/185980/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185980/

Comment 8

[Florian Quèze [:florian]]

Comment on attachment 8914659 [details]
Bug 1404674 - Clicking the home button should focus the content area.

https://reviewboard.mozilla.org/r/185980/#review191008

I'm a bit reluctant to add more .focus() calls, as each of them triggers a style flush, but I think BrowserGoHome can only be triggered by a user action, and should never happen several times in a row, so I think this is fine here.

If we care about this behavior enough to fix it, should we also add test coverage to prevent future regressions?

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e544746f88e0
Clicking the home button should focus the content area. r=florian

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e544746f88e0

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Can this ride the 58 train or should we consider it for backport?

Comment 12

[Dão Gottwald [:dao]]

Comment on attachment 8914659 [details]
Bug 1404674 - Clicking the home button should focus the content area.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1399454
[User impact if declined]: focus remains in the address bar when clicking the home button
[Is this code covered by automated tests?]: not yet
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial fix
[String changes made/needed]: /

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8914659 [details]
Bug 1404674 - Clicking the home button should focus the content area.

Recent regression, Beta57+

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/29c2c1ade870

Comment 15

[Ciprian Georgiu, Desktop QA]

Reproduced this issue using an affected Nightly build from 2017-09-30 on Win 10.

Verified fixed on latest Nightly 58.0a1 (2017-10-09) and 57.0b6 (20171005195903) across platforms: Win 10, 7, Ubuntu 16.04 x64 and Mac OS X 10.11.