Closed
Bug 1404803
Opened 7 years ago
Closed 7 years ago
When using discrete animation with an "empty" nsSMILCSSValueType value the zero-value fixup never happens
Categories
(Core :: SVG, defect, P3)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla58
People
(Reporter: birtles, Assigned: birtles)
References
Details
Attachments
(3 files, 1 obsolete file)
1.61 KB,
patch
|
Details | Diff | Splinter Review | |
5.30 KB,
patch
|
Details | Diff | Splinter Review | |
59 bytes,
text/x-review-board-request
|
hiro
:
review+
|
Details |
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
(Accidentally left the begin="indefinite" in from another test)
Assignee | ||
Updated•7 years ago
|
Attachment #8914211 -
Attachment is obsolete: true
Assignee | ||
Comment 3•7 years ago
|
||
This patch fixes the bug but it's awefully complicated for something that, as far as I can tell, only ever happens with a discrete non-additive SMIL by-animation. That also makes it really hard to test the code here so I'm a bit uncomfortable about landing something as complicated as this given how unlikely it is to be exercised. Perhaps I can find other ways to test/simplify it.
Updated•7 years ago
|
status-firefox57:
--- → wontfix
Priority: -- → P3
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•7 years ago
|
||
I'm not sure if this patch is worth it honestly. It fixes the behavior but it introduces a fair bit of code for a very rare case.
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8915023 [details] Bug 1404803 - Convert empty values to suitable zero values even when using discrete interpolation; https://reviewboard.mozilla.org/r/186292/#review191616 ::: dom/smil/nsSMILAnimationFunction.cpp:491 (Diff revision 1) > + // We have currently only ever encountered this case for the first > + // value of a by-animation (which has two values) and since we have no > + // way of testing other cases we just skip them (but assert if we > + // ever do encounter them so that we can add code to handle them). > + if (index + 1 >= aValues.Length()) { > + MOZ_ASSERT(static_cast<void*>(aResult.mU.mPtr), Is this static_cast necessary?
Attachment #8915023 -
Flags: review?(hikezoe) → review+
Comment hidden (mozreview-request) |
Pushed by bbirtles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d8974272e3e3 Convert empty values to suitable zero values even when using discrete interpolation; r=hiro
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d8974272e3e3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•